Upgrade Rollbar.js version

Sorry, 7.x is minimally maintained and maintenance fixes only.

This patch is the definition of a maintenance fix:

This project is considered feature complete by its present owner.

The project has reached the target the owner/maintainer aimed for, and as a general rule, no new features will be added (though it's always possible to make a compelling case). Bug reports filed in the project's issue queue are looked at and eventually fixed. If a patch is provided to fix an issue, it may lead to a more timely issue resolution.

If you're genuinely not going to apply this patch then the module should be marked No further development

@vijaycs85 has kindly let me help maintain the 7.x branch of this module. When this has been RTBCd I'd be happy to apply it.

@eddie_c, I doubt whether this can be marked RTBC as there are only 30 sites report using this module primarily as this has never had a stable release for 7.x

I can report that I applied this patch successfully myself, plus with a bit of manipulation managed to get the module to work with the latest Rollbar release (1.4.1) which requires installation via composer

@intrafusion Great to hear that it works for you. Please could you expand on the manipulation you had to do to get it to work with Rollbar 1.4.1?

@eddie_c it was fairly straightforward:

1. You need to install Rollbar for PHP using composer, I did this by following steps 1-3 at Manual installation if you are not using composer.json for your project, at step 2 I was in sites/all/libraries before running git clone
2. At the top of rollbar.module, there is a helper function _rollbar_get_library_path(), I set the default value to sites/all/libraries/rollbar-php/vendor/autoload.php
3. There are 2 instances where the class Rollbar is called, one inside rollbar_boot() and one inside rollbar_watchdog(), these calls need to be changed from Rollbar:: to \Rollbar\Rollbar::

These were the only steps I needed to take to get it working, however I discovered that if you try to upgrade a site which already has Rollbar installed there are serious errors, but if you install fresh it works without issue. I suspect that this due to the variable in _rollbar_get_library_path() returning the wrong path, etc.

jesse.d This is a good point. Also, if we're going to upgrade the Rollbar PHP library as @intrafusion suggests then perhaps we should be using this method for integrating with Rollbar.js: https://github.com/rollbar/rollbar-php#integration-with-rollbarjs

My concern is that we'd be introducing a dependency on composer and I don't know if that's acceptable in a Drupal 7 module. Do you know?

Thanks @jesse.d. Following up on your advice I've created a patch that introduces a dependency on Composer Manager in order to use the latest version of the PHP Rollbar library (which also includes a more up to date Rollbar.js).

As @intrafusion pointed out, this breaks backwards compatibility with Rollbar 7.x-1.x, so I suggest if we go with this solution we commit it to a new 7.x-2.x branch.

I've not tested this thoroughly yet, but initial testing shows I'm at least getting some messages showing successfully in rollbar.

An update of the previous patch to add in an extra class_exists() check to stop it failing

Another update, adding a missing composer.json file and a few other fixes

@retrodans, Should the rollbar library version be pinned to v1.x or v1.7.x in order to avoid composer upgrading to a version that may not be compatible with the module in future?

Other than that, I've tested this and it appears to work well.

Patch applied to new 7.x-2.x branch