Yes this is a very useful and important addon. Thank you.

However, in our quick test it appears that the bcc does not work on our site.

It is good to see that the 24-hour time limit is independent of the Drupal $timeout variable which for our site users has been increased. This independence is good and makes all the email notifications and system messages consistent.

Just need the bcc working. Thanks,

Izzy

Comments

jaydub’s picture

it's not documented yet but the emails don't go out if
an admin or a user with permissions to administer users makes
the email change.

If that's not the case for you are you able to verify that the
email was sent to the intended user but failed to send to
the BCC?

thanks

izmeez’s picture

The original test was with an account that does not have any administrative permissions and the bcc was sent to admin@mysite.com (because I wasn't sure if admin would get a notice and was prepared to look for two). The email did not go to admin, either directly or as the bcc. But, it did work in terms of going to the users old and new email address.

I have also tested with the bcc address being some other user and got the same results; works for users old and new address but no message to admin or bcc.

Also, minor point, but none of the emails show they are being copied so they are all technically bcc and the bcc field essentially just gives a choice of directing the email to other than the admin. This may be good but could also introduce some fragmentation. I wonder if by default it should send an email to admin so if that address is changed for other reasons all admin stuff would still reach the admin person. You might also have a desire for the bcc field, or it may be an optional redundancy.

I have also checked and the change link works fine if used within the 24 hours which is perfect. Thanks,

Izzy

izmeez’s picture

I also just checked out the undocumented feature you describe that when the admin changes the email address no emails are sent out and that seems to work just fine. Thanks,

Izzy

jaydub’s picture

I won't have time to test it as I'll be out of town
but I've committed a quick fix to CVS

Look for the string containing:

  if ($bcc) {
    $params['headers']['Bcc'] = $bcc;
  }

and change the 'Bcc' to 'bcc'

izmeez’s picture

Status: Active » Fixed

That works.

Thank you. I've changed status to fixed, hope that's ok.

Izzy

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

izmeez’s picture

Title: bcc doesn't seem to work » Email Confirm, bcc doesn't seem to work

I was just checking on the status of this and noticed that the 6x-1.x-dev dated 2008-Jul-18 does not have the bcc fix in it neither does the 6x-1.1 from earlier on 2008-Jun-05. So, it is still necessary for this to be changed by anyone using the module until the fix is committed. Thanks,

Izzy

izmeez’s picture

Title: Email Confirm, bcc doesn't seem to work » Email Confirm, again bcc doesn't seem to work
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Closed (fixed) » Active

I hope this is the correct thing to do. I have changed the title of this issue just a little and changed the status from closed to active.

Today, I discovered that the bcc was again not working in email_confirm. This seems odd as it was definitely working several months ago when we installed it with the changed of one occurrence of "Bcc" to "bcc". I have tried all three versions again 1.1, 1.x-dev, and 1.0 and ensured the change from "Bcc" to "bcc" was made in each of them but the bcc still does not work. The only other change that may be relevant is that the version of Drupal is now 6.4 but I am not sure if this is a cause of the problem.

I would appreciate knowing if anyone else has encountered this problem and any help in correctling this. Thanks,

Izzy

izmeez’s picture

My apologies. I have tested this further with a new Drupal test site using just email_confirm using the 6.x-1.x-dev version with the change of "Bcc" to "bcc" as previously described and it does appear that the bcc is sent out even on the Drupal 6.4 version. So, I may be dealing with a conflict resulting from other components in the setup I was using in my previous testing earlier today.

That being the case, the only change that needs to be committed would appear to be the single change of "Bcc" to "bcc".

I will advise you when I am able to identify the conflict if it is useful for others to know.

Thanks again for this useful module.

Izzy

jaydub’s picture

i went ahead and made new releases of d5 and d6 versions as there
was another change added since the last release.

izmeez’s picture

Title: Email Confirm, again bcc doesn't seem to work » Email Confirm, bcc now working
Status: Active » Fixed

Thanks again. I have installed the latest version and it seems to be working fine. I would vote for this module being considered part of Drupal core but I am not sure how modules get considered for inclusion in core.

Izzy

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.