Closed (fixed)
Project:
Google reCAPTCHA
Version:
7.x-1.0
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
22 Jul 2015 at 15:12 UTC
Updated:
10 Mar 2016 at 15:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nileshlohar commentedHere's the patch.
Comment #2
sergey-serovGood day, nileshlohar.
Thank You very much for patch.
Buy the way, how You disable uid 1? Seems it is good idea.
Comment #3
nileshlohar commentedThanks sergey-serov !
You can create another user with administrator rights then edit User:1 (/user/1/edit) and choose status blocked.
Comment #4
nileshlohar commentedHi sergey-serov,
By when, i can expect that you will review and commit the patch ?
Comment #5
sergey-serovGood day, nileshlohar!
Thank You again for patch.
New release will be published very soon.
Comment #6
sergey-serovGreetings!
New release 7.x-1.1 is complete and published.
Again, thank You very much for Your patch!
Comment #7
nileshlohar commented@sergey-serov: why can't I see the commit of this issue ?
Not even on https://www.drupal.org/node/2468941/commits.
How you updated code? you didn't committed on git?
Comment #8
sergey-serovThree questions in one comment :)
Yes, this is strange that here only one commit: https://www.drupal.org/node/2468941/commits
If You will help with this it will be great!
Certainly fresh code was committed and uploaded to git.drupal.org - and based on this code was created new release. Why it is not present in the list of commits not clear for me too.
Comment #9
nileshlohar commentedhave you followed these guidelines https://www.drupal.org/node/711070#committing-locally ?
Comment #10
sergey-serovI used something like this:
Maybe something with tag not properly. On repository on github no tag, but I had push code after adding tag.
https://github.com/sergey-serov/drupal_google_recaptcha/commits/master
Comment #11
nileshlohar commentedSo you mean you committed on GitHub and not on drupal git repository?
git instructions are also available at: https://www.drupal.org/project/google_recaptcha/git-instructions
Comment #12
sergey-serovNo nileshlohar, without updating repository on git.drupal.org is impossible to create new release.
Updates were in both repositories.
Comment #13
nileshlohar commentedI am not getting it then why the commits are not visible anywhere.
I think if proper instructions followed as mentioned in [#711070] it should reflect everywhere
including project page, our profiles and this issue like https://www.drupal.org/node/2018593#comment-10039149
Anyways if possible you can commit it once again ;)
Comment #14
sergey-serovBoth commits are presents in drupal repository:
http://cgit.drupalcode.org/google_recaptcha/
Tag Download Author Age
7.x-1.1 commit 2f77ce9074... Sergey Serov 9 days
7.x-1.0 commit 61893be58b... Sergey Serov 11 months
Rather strange, is not it? :)
I have one suggestion - different emails in git settings.
Comment #15
nileshlohar commentedYes, strange it is !!!
I think we missed something.
sorry, I didn't got your suggestion.