Hi,
I've just recognized by accident, that calling the page with an not existing anchor in the URL will lead to a JS error, which further breaks any other scripts on the page. ("TypeError: $(...).offset(...) is undefined" in line 12 of single-page-site-scroll.js)

However, this is very easy to fix. I will attach a patch in a few minutes...

CommentFileSizeAuthor
#2 fix_js_error_on_invalid_url_hashes-2533774-2.patch518 bytesagoradesign
#1 fix_js_error_on_invalid_url_hashes-2533774-1.patch938 bytesagoradesign

Comments

agoradesign’s picture

agoradesign commented
Status: Active » Needs review
StatusFileSize
new fix_js_error_on_invalid_url_hashes-2533774-1.patch938 bytes

voila

agoradesign’s picture

agoradesign commented
StatusFileSize
new fix_js_error_on_invalid_url_hashes-2533774-2.patch518 bytes

I've just had a strange issue when applying my own patch created with "git format-patch" command.

This is an alternate version created with the simpler "git diff" command, if you encounter the same problem.

That's the only difference, it's still the same patch

robin.ingelbrecht’s picture

robin.ingelbrecht commented
Status: Needs review » Fixed

Thanks for the patch. Committed the changes WITH your username as author ;)

agoradesign’s picture

agoradesign commented

loooool thanks for committing :)))

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.