'Due to existing settings, could not track when a redirect is used, so could not remove unused redirects.'

Did this just start happening for you? I've just noticed it filling the logs on a site today.

Can anyone please screenshot their /admin/config/search/redirect/settings page for me?

Here's a screenshot - I'm having the same problem!

Ah, it's due to the 'Do not discard' setting, which is actually the default value. I guess we shouldn't be displaying a watchdog message in that case, since it is pretty common.

Unfortunately for comment #4, I use "Discard after 3 months" setting (see attached screen capture) and the message still appears (patch not applied):

• clear watchdog
• run cron
• message is back in the watchdog

PS: auto redirects is disable for dev purposes.

I don't think there's any point in logging the message, it's just noise.

This patch removes the message and appends a note to the option on the settings form indicating that the page_cache_invoke_hooks variable defaults to TRUE.

Sure, there is more relevant things to fix ;-)

I agree with Damien, that logging this is just noise. A good description on the settings page should be enough!

Considering this was requested by users in the first place, obviously not having a message wasn't enough. Please try out the dev release which should get rid of this message if you have the 'expire redirects' setting disabled (which is the default).

@Dave Reid: Ah, ok, reasonable enough.

This patch just adds an indication on the settings page that the variable is set to TRUE by default.

does 12 remove the watchdog reference?

this was odd. i applied the patch, but continued to get errors on cron runs (executed from crontab) until i logged in to the site in a browser and hit Save on the Redirect settings page. without changing anything. now it seems to have stopped.

i am not following this part:

  if (!variable_get('redirect_page_cache', 0) || !variable_get('page_cache_invoke_hooks', TRUE)) {
    // If serving redirects from the page cache is enabled and hooks are not
    // executed during page caching, then we cannot track when a redirect is
    // used. Therefore, we cannot remove unused redirects.

doesn't !variable_get('redirect_page_cache', 0) mean that serving redirects from the page cache is not enabled?

the reason for the odd behavior described in 14 is that redirect_purge_inactive was set to '4838400' which is not zero but also not a currently allowed value. so the settings form defaults to zero, and saving it prevents the cron due to the change in the patch.

i still don't follow the logic of that watchdog warning, nor does the message itself convey any meaning to me particularly, but it looks like it's working correctly on its own terms with that fix.

Ah, I think I know how this needs to be fixed. We should be displaying this message only if: saving redirects to the page cache is enabled and the page_cache_invoke_hooks variable is set to FALSE. This does not match the current logic.

Patch attached for review.

Combined with improved message in the settings form.

Tested and committed #17 to 7.x-1.x.

Woot! :-)