Missing label and description for exposed numeric filter when using 'between' filter

Added tests as mentioned in #2.

Looks good. Manually tested it, added screenshots.

+++ b/core/modules/views/src/Plugin/views/filter/NumericFilter.php
@@ -199,7 +199,7 @@ protected function valueForm(&$form, FormStateInterface $form_state) {
+        '#title' => !$exposed ? $this->t('Min') : $this->exposedInfo()['label'],

Should we add 'between' after this or just leave it to the site builder to do so. Adding between would leave you with a sensible default when people don't change the label. And since you are stuck with 'And' as the label for the max field so adding more hardcoded labels might not be that bad. Just a thought...

Might as well fix that the description is not shown either when using the 'between' filter. Fix and test for that. Bit of a scope creep, but fits in so nicely with the other fix.

+++ b/core/modules/views_ui/src/Tests/FilterNumericWebTest.php
@@ -92,6 +92,30 @@ public function testFilterNumericUI() {
+    $this->assertText('And');
+    $this->assertText('Age between');
+    $this->assertText('Paul');
+    $this->assertText('Ringo');
+    $this->assertText('George');
+    $this->assertNoText('Meredith');
+    $this->assertNoText('John');
+    // Test if the description is shown.

It seems to be that we should not just the existence of the strings on the page but better also some css selectors. In general this test is about the exposed filter labels, so I don't get why we need to check for the actual view result using Paul, Ringe, George etc.

@dawehner so maybe something like this?

Seems like the Beatles names test are there to check the proper working of the filter, those asserts are also done for the other filter settings in the same test. But since there is test coverage for the proper working of the filter in Drupal\views\Tests\Handler\FilterNumericTest that seems redundant.

+++ b/core/modules/views_ui/src/Tests/FilterNumericWebTest.php
@@ -92,6 +92,26 @@ public function testFilterNumericUI() {
+    $this->assertRaw("<div id=\"edit-age-min--description\" class=\"description\">\n      Description of the exposed filter\n    </div>", 'Between filter description found');

IMHO we should really use cssSelect() instead. The test should not bind everything to the rendered HTML.

Changes per #9 to check for css selector and not the whole HTML with all the spaces and stuff.

+++ b/core/modules/views_ui/src/Tests/FilterNumericWebTest.php
@@ -110,8 +110,9 @@ public function testFilterNumericUI() {
+    $this->assertEqual(count($this->cssSelect('.form-item-age-min .description')), 1);
+    $this->assertText('Description of the exposed filter');

Why do you not look into the result of cssSelect? The description is in there ...

Yeah the description is there but still with all the extra whitespace characters, so needed to trim() it to make it ok (and not add all the whitespace crap to the test).

Thank you for doing that though!

Committed 63c3cac and pushed to 8.0.x and 8.1.x. Thanks!