I recently started seeing exceptions when running Honeypot tests via SimpleTest, and it looks like they're related to All TestBase derived tests now enforce strict configuration schema adherence by default. So I'll need to look into the Configuration schema/metadata docs and see what's the best way to get this moving.

Some of the Honeypot configuration is dynamic, generated per-node-type or per-comment-type, etc., so hopefully there's a graceful way to do that. For now, I'm adding the hack protected $strictConfigSchema = FALSE; in Honeypots tests.

CommentFileSizeAuthor
#2 honeypot-strict-schema-2403757-3.patch2.17 KBmr.baileys
#2 config-inspector-honeypot.png122.81 KBmr.baileys

Comments

  • geerlingguy committed 48f5ccd on 8.x-1.x 
    Issue #2403757 by geerlingguy: Disable strict config schema in tests for...
mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Assigned: Unassigned » mr.baileys
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new config-inspector-honeypot.png122.81 KB
new honeypot-strict-schema-2403757-3.patch2.17 KB

Patch attached that:

  • Adds an explicit schema for honeypot.settings.
  • Tweaks the existing tour.tour.honeypot.yml config so it adheres to the tour.tour.* schema, and moved it to optional so no test failure for a missing schema is encountered during testing.
  • Re-enables strict config schema checking during testing.

Tested with Config Inspector and verified that all honeypot configuration settings are now correctly validated:
Honeypot schema inspection.

geerlingguy’s picture

geerlingguy commented

@mr.baileys - awesome! Thanks for the work on this patch; if it passes on the testbot run, I'll commit. This is one of those tasks I probably would've just put off forever, so I'm glad someone had the initiative to get it fixed :)

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.