I found this because of http://drupal.org/node/239084.

Function _comment_subscribe_mailalert has a watchdog call that is incorrect for 6.x:

  watchdog('comment_subscribe', t('Subscribe ') . $mylink, 
  WATCHDOG_NOTICE, l(t('source comment'), 'node/'. $nid, array('fragment' => 'comment-'. $alert->cid)));

Needs to be something like:

  watchdog('comment_subscribe', 'Subscribe !link', array('!link' => $mylink), 
  WATCHDOG_NOTICE, l(t('source comment'), 'node/'. $nid, array('fragment' => 'comment-'. $alert->cid)));

In addition I see many coding standards violations in this module. Please use the Coder module to identify them. It probably would also have alerted you to the watchdog changes.

Comments

zyxware’s picture

zyxware commented

The error has been fixed and updated in the next version.
Cheers
zyxware

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Thank you. Please mark this issue fixed when it has been committed (even if only to the -dev release).

zyxware’s picture

zyxware commented
Assigned: Unassigned » zyxware
Status: Active » Fixed

Marking the issue as fixed

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

LynnS’s picture

LynnS commented

I just d/l'ed this module off the modules page, and the bug was still there. I'll go to CVS and see if I can find a more current version, but I thought you should know.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Closed (fixed) » Active
superjacent’s picture

superjacent commented

I'm coming from this thread http://drupal.org/node/260430 which I posted a few weeks ago.

Which file do I need to access in order to edit the function _comment_subscribe_mailalert as mentioned above.

zyxware’s picture

zyxware commented
Status: Active » Fixed

Hi superjacent,

You have to edit comment_subscribe.module file in comment_subscribe module.

Regards
zyxware

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Fixed » Active

In addition, the first parameter to watchdog() is limited to 16 characters if the database logging module is installed (true for a guess of about 99% of Drupal sites). "comment_subscribe" is 17 characters and will fail the SQL query. Please change it to "comment_subscrib" or "commentsubscribe".

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

EDIT: Removed comment. Posted in wrong issue. :)

zyxware’s picture

zyxware commented
Status: Active » Closed (won't fix)

It has been decided to merge Comment Subscribe module with the Comment Notify module as both currently have the same set of functionalities. We have stopped our support here and will be providing our support at the Comment Notify issue queue. To help you seamlessly migrate to Comment Notify, we have provided an easy migration pathway using the last update - 6.x-1.4. Migration instructions are provided at the Comment Subscribe project home page . Once again thank you all for your wonderful support and contributions towards this module. See you all at the Comment Notify issue queue :-)