Closed (fixed)
Project:
Profile Complete Percent
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Support request
Assigned:
Reporter:
Created:
1 Dec 2014 at 14:44 UTC
Updated:
28 Mar 2015 at 12:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
perennial.sky commentedHere is the link of ported pcp module.
https://github.com/akashjain132/pcp
Comment #2
BarisW commentedHi Akashjain,
thanks so much for taking the effort to port the module to Drupal 8.
Apologies for not being able to review the code sooner.
I just reviewed the code and I must say that I'm impressed ;)
For now, it's good to go. It still needs a bit of love, but let's create the D8 version now and polish it later.
Some things that are missing:
Plus, I'd like to change some texts
'#title' => $this->t('GENERAL SETTINGS'),to'#title' => $this->t('General settings'),description: 'pcp module use to show user field status.'todescription: 'Displays whether the user completed all profile fields.'Comment #4
BarisW commentedHere it is: https://www.drupal.org/node/2399149
I'll leave this issue open for the follow-ups. Feel free to commit them yourself, since you have access.
Comment #5
tkuldeep17 commentedHi Akashjain,
Nice work.. I have tried to enable this module in my local setup. it was giving error. As now "ConfigFormBase" is required to implement one more function "getEditableConfigNames()" which returns configuration settings.
I am attaching patch for same.
Comment #6
tkuldeep17 commentedComment #7
perennial.sky commentedThanks tkuldeep17, for your valuable patch, but this patch needs further reroll, so i fixed this.