CommentFileSizeAuthor
#5 pcp_d8_2385019-5.patch619 bytestkuldeep17

Comments

perennial.sky’s picture

Here is the link of ported pcp module.

https://github.com/akashjain132/pcp

BarisW’s picture

Hi Akashjain,

thanks so much for taking the effort to port the module to Drupal 8.
Apologies for not being able to review the code sooner.

I just reviewed the code and I must say that I'm impressed ;)
For now, it's good to go. It still needs a bit of love, but let's create the D8 version now and polish it later.

Some things that are missing:

  • A link in to the config page from the modules page
  • A page to change the settings (it's not showing up in the interface yet)

Plus, I'd like to change some texts

  • '#title' => $this->t('GENERAL SETTINGS'), to '#title' => $this->t('General settings'),
  • description: 'pcp module use to show user field status.' to description: 'Displays whether the user completed all profile fields.'
  • Also, I'd the to be consistent with naming the module. Now Profile Completeness Percentage / PCP / pcp are used randomly. I would suggest to write the full name everywhere (except for system names / variable names).

  • BarisW committed a247ede on 8.x-1.x authored by akashjain132
    Issue #2385019 by akashjain132, BarisW: First D8 version of the PCP...
BarisW’s picture

Status: Active » Needs work

Here it is: https://www.drupal.org/node/2399149

I'll leave this issue open for the follow-ups. Feel free to commit them yourself, since you have access.

tkuldeep17’s picture

StatusFileSize
new619 bytes

Hi Akashjain,
Nice work.. I have tried to enable this module in my local setup. it was giving error. As now "ConfigFormBase" is required to implement one more function "getEditableConfigNames()" which returns configuration settings.

I am attaching patch for same.

tkuldeep17’s picture

Status: Needs work » Needs review
perennial.sky’s picture

Status: Needs review » Fixed

Thanks tkuldeep17, for your valuable patch, but this patch needs further reroll, so i fixed this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.