cannot unpublish class events

I'm having this issue as well using 7.x-1.0-rc2 in the latest version of the CM Starterkit Difficult.

We're using version 7.x-1.0-rc1+8-dev and this doesn't seem to be an issue.

That maybe because I don't have the option to set Publishing settings on any Multi-day event nodes - they're just published by default - so the only way to remove an event is to delete it.

I can edit the nodes and the changes stick.

@stefanwray - you could - but I don’t think we’ve every had the publishing options enabled.

so that may not be the thing, even if it “fixes” things.

I am using 7.x-1.0-rc2, CivCRM 4.4.7, and beta7 of the Moderate CM starter kit and am experiencing the same issue.

Is there any particular reason why this is a task and not a bug report?

Furthering this, I also noticed that changes to the event title are not update, however I can update content in the body.

I thought this may have been a regression, but it doesn't look like this ever worked as expected. Looking have at rc1, the initial save has the necessary logic...

http://cgit.drupalcode.org/civicrm_multiday_event/tree/civicrm_multiday_...

but the update hook doesn't...

http://cgit.drupalcode.org/civicrm_multiday_event/tree/civicrm_multiday_...

The latest patch has resolved my issues. I can unpublish and re-publish nodes for multiday events as well as modify the title field.

@bagelche, so should we now set this to RTBC so that the maintainer knows to roll a new release? Is all the testing done at this point?

I'm hesitant to switch it to RTBC because we seemed to experience the issue across different versions of the module, distribution, and CiviCRM. I'd feel more comfortable if we heard from someone with at least one different variable of those three than me. But, so far it's working for me and hasn't broken anything else, so if someone else gives it a review, I think we'd be cleared for takeoff.

I can confirm that this patch allows me to unpublish Workshop nodes and it sets the CiviEvent to Active: No and Public: No. When I republish the node the CiviEvent gets set to Public:Yes but Active is still No. This isn't a huge deal and it might be out of scope for what needs to happen here but could result in confusion if the user thinks that just republishing the node will be all that's needed to set the CiviEvent to Active again. I'm marking this RTBC as the stated issue has been resolved.

There 2 setting in admin/config/civicrm/civicrm-multiday-event related to publishing vs. unpublishing a node.

Both the CiviEvent's Public and Active state should be able to be modified or ignored based on these settings. Are you saying that you have the active setting checked, but it's not changing?

@kreynen, both of those settings are checked and work when unpublishing a node but when I tried to republish the node only Public was changed back to yes. The other setting for Active remained No.

@avguy... thanks for clarifying. I've already opened #2378907: Make module more efficient by combining hook_presave and hook_field_attach_presave with some ideas about completely changing the way this works. Because the updates fixed the original issues (which has been a bug for > a year), I going to mark this as fixed.

Can you open a new issue about the Active/Not Active changes not working as expected and we can tackle that in the next update along with #2368933: Event Description not showing if we can reproduce that.