Post patches to the issue to update module with last core changes

CommentFileSizeAuthor
#8 update_email-2360037-8.patch4.71 KBgambry
#4 fix-test.patch2.24 KBandypost
email_registration_d8_refactoring.patch4.19 KBkallehauge

Comments

berenddeboer’s picture

berenddeboer commented
Status: Active » Reviewed & tested by the community

  • andypost committed c1c9938 on 8.x-1.x 
    Issue #2360037 by kallehauge, Petrica, andypost: Refactor code for...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Refactor code for Drupal 8 beta » Update email registration to follow Drupal 8 changes
Issue summary: View changes
Status: Reviewed & tested by the community » Active
Issue tags: -#Drupal8, -8.0.0-beta1

I fixed the patch and incorporate changes from duplicates
#2382653: Drupal 8, beta 3 update - registration errors
#2382701: Drupal 8, beta 3 update - User login error

Let's left this open to continue update while core changes

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new fix-test.patch2.24 KB

Fix tests

The last submitted patch, email_registration_d8_refactoring.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: fix-test.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Active

Test fixed, now we need to extend tests to make sure that all forms altered without errors

gambry’s picture

gambry
Primary language Italian
Location Milan
commented
StatusFileSize
new update_email-2360037-8.patch4.71 KB

In this patch:
- Code re-factoring to better follow drupal standards
- Removing deprecated calls
- Removing useless db_update on email_registration_user_insert()
- Adding test for email_registration_unique_username()

estoyausente’s picture

estoyausente
Primary language Spanish
commented
Status: Active » Reviewed & tested by the community

The patch apply correctly and the code is much better than before. We need a little push over this module, it is simple and the use case is very common.

Can be this patch committed?

andypost’s picture

andypost
he/him
Primary language Russian
commented

Thanx, looks great, will commit asap

Minor nit

+++ b/email_registration.module
@@ -42,17 +44,12 @@ function email_registration_user_insert(UserInterface $account) {
+ * Make the username unique.

s/Make/Makes

  • andypost committed 37e888d on 8.x-1.x authored by gambry 
    Issue #2360037 by andypost, gambry: Update email registration to follow...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Thanx, fixed on commit and pushed
Beta version coming

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.