For string $db_url values, the current code for fast_404_validate_path_mysql() only extracts the first character from $db_url and then tries to parse it:

http://3v4l.org/0jpsV

This patch fixes things:

http://3v4l.org/PiFjS

CommentFileSizeAuthor
Selection_651.png72.43 KBjanusman
Selection_650.png65.51 KBjanusman
fast_404_validate_path_mysql-string-dburl-fix.patch1.01 KBjanusman

Comments

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented

Alejandro! I'm pushing for the patch in #2078863: Provide PDO db access in fast_404_path_check [patch attached] to be committed to use PDO instead of mysql functions. I'm hoping this will mitigate these issues. If you could test that I'd be happy to make that the defacto standard for this module (I wrote the patch prior to becoming a committer so don't feel it's right to merge that without a review!)

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented

Removing comment duplicate.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented

Wait, I just saw this was for the 6.x version of the module.

  • typhonius committed c316c22 on 6.x-1.x authored by janusman 
    Issue #2346979 by janusman: fast_404_validate_path_mysql never works for...
adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Status: Needs review » Closed (fixed)

Committed to 6.x thanks!

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented

Committed to 6.x thanks!