Problem/Motivation
#1:
Unfortunately this is a fairly obvious user-facing bug. It'd be awesome if there were some way to fix it tomorrow during the QA sprint.
Proposed resolution
Thanks so much @webchick!
+++ b/core/themes/bartik/css/layout.css
@@ -32,7 +32,7 @@ body,
+.region-secondary-menu .block-menu {
...
overflow: hidden;
This is likely the cause of the first issue. Overflow hidden is ways that case. And likely that class is providing a clearfix which can be replaced by removing it (if the clearfix is no longer necessary) or convering it to a clearfix:
.region-secondary-menu .block-menu:after {
content: "";
display: table;
clear: both;
}
Remaining tasks
Create a patch
Manual testing
User interface changes
API changes
Follow-up to #1869476: Convert global menus (primary links, secondary links) into blocks
Comment | File | Size | Author |
---|---|---|---|
#8 | fix-contextual-link-clipping.patch | 981 bytes | skippednote |
#7 | fix-contextual-link-clipping.patch | 972 bytes | skippednote |
#4 | fix-contextual-link-clipping.patch | 972 bytes | skippednote |
Comments
Comment #1
tstoecklerThe issue title majorly WTF-ed me today... :-)
Comment #2
joelpittetThanks should clone issues as follow ups that late at night. Whoops
Comment #3
star-szrSuggested re-title :)
Comment #4
skippednote CreditAttribution: skippednote commentedSince the content is in a block level element I don't think there is a need to float and clearfix the navigations. Simple
text-align
fixes the problem here while reducing the code smells.Comment #5
skippednote CreditAttribution: skippednote commentedComment #6
Wim LeersThat sounds sensible, but I'm no CSS expert, so I can't approve this. This issue is already tagged with "CSS" so I'm sure it'll be reviewed shortly.
In the mean time, there's one detail that's wrong:
Please keep the
/* LTR */
annotation.Comment #7
skippednote CreditAttribution: skippednote commentedAdd
/* LTR */
back.Comment #8
skippednote CreditAttribution: skippednote commentedHad added the same patch.
Re-uploading with
/* LTR */
.Comment #9
skippednote CreditAttribution: skippednote commentedComment #10
joelpittetThanks @skippednote that does the trick.
Screenshots in #4 and I manually tested rtl ltr on simplytest.me.
Comment #11
trogels CreditAttribution: trogels commentedReviewed and tested #8 patch. Looks good.
Comment #12
NBZ4live CreditAttribution: NBZ4live commentedMarked #2349781: Quick edit context menu not visible in the User account menu in Bartik as duplicate of this issue
Comment #15
joelpittetComment #16
joelpittetBack to RTBC, Testbot
Was at the "coffeeshop"
Comment #17
alexpottCommitted d21cea7 and pushed to 8.0.x. Thanks!