Follow-up to #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules

3 occurrences of the word "enabl". Might not need to change all 3. Please check if the occurrence in BreakpointThemeTest.php needs to be changed.

1 occurrence of the word "disabl". Might not need to be changed Please check.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

Priority: Critical » Normal
jarsenx’s picture

Three occurrences of the word "enable"
Recommend changing the first two to read "* Modules to install."
Third does not need to change.

->grep -r 'enabl' breakpoint/*
breakpoint/src/Tests/BreakpointGroupTestBase.php:   * Modules to enable.
breakpoint/src/Tests/BreakpointTestBase.php:   * Modules to enable.
breakpoint/src/Tests/BreakpointThemeTest.php:    theme_enable(array('breakpoint_test_theme'));

One occurrence of the word "disable"
Does not need to change

->grep -r 'disabl' breakpoint/*
breakpoint/tests/src/BreakpointGroupConfigEntityUnitTest.php:   ->disableOriginalConstructor()->getMock();
jarsenx’s picture

Assigned: Unassigned » jarsenx
jarsenx’s picture

Status: Active » Needs review
jarsenx’s picture

Patch change_enabl_to_install_disabl_to_uninstall-2318801-4.patch is ready for review.

jarsenx’s picture

Assigned: jarsenx » Unassigned
jarsenx’s picture

Assigned: Unassigned » jarsenx

Status: Needs review » Needs work

The last submitted patch, 5: change_enabl_to_install_disabl_to_uninstall-2318801-5.patch, failed testing.

RainbowArray’s picture

Issue tags: +Needs reroll, +Novice

Needs a reroll, but patch is still relevant. Should be an easy fix.

RainbowArray’s picture

Status: Needs work » Fixed

Oops. I was looking at Alpha 12. This fix is no longer needed due to #2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level.

jarsenx’s picture

Status: Fixed » Needs review
Issue tags: -Needs reroll
FileSize
469 bytes

Recreated patch for enable/disable issue.

mbrett5062’s picture

I have downloaded latest 8.0.x-dev and searched within core/modules/breakpoint for "enabl" and "disabl".

Here are results

Searching 13 files for "enabl"

C:\Users\Michael\Documents\Drupal\D8 releases\drupal-8.0.x-dev\core\modules\breakpoint\breakpoint.module:
38
39 /**
40: * Implements hook_themes_enabled()
41 */
42: function breakpoint_themes_enabled($theme_list) {
43 \Drupal::service('breakpoint.manager')->clearCachedDefinitions();
44 }

C:\Users\Michael\Documents\Drupal\D8 releases\drupal-8.0.x-dev\core\modules\breakpoint\src\Tests\BreakpointDiscoveryTest.php:
17
18 /**
19: * Modules to enable.
20 *
21 * @var array
..
25 protected function setUp() {
26 parent::setUp();
27: \Drupal::service('theme_handler')->enable(array('breakpoint_theme_test'));
28 }
29

4 matches across 2 files

Searching 13 files for "disabl"

C:\Users\Michael\Documents\Drupal\D8 releases\drupal-8.0.x-dev\core\modules\breakpoint\breakpoint.module:
45
46 /**
47: * Implements hook_themes_disabled()
48 */
49: function breakpoint_themes_disabled($theme_list) {
50 \Drupal::service('breakpoint.manager')->clearCachedDefinitions();
51 }

2 matches in 1 file

Found only the one instance of "Module - enable"

As far as I can see this issue/patch is good to go.

mbrett5062’s picture

Status: Needs review » Reviewed & tested by the community

Setting to RTBC as per comment #13 above.

  • webchick committed a9854ee on 8.0.x
    Issue #2318801 by jarsenx, mbrett5062: Breakpoint Module: Fix...
mbrett5062’s picture

@webchick, sorry if I am completely wrong here, but should this not have been moved to status "Fixed" before committing? Will the automated issue queue thing pick this up and close after 2 weeks if it is not set to fixed?

Ignore me if I am being silly, I know nothing, and very well I might say.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: change_enabl_to_install_disabl_to_uninstall-2318801-12.patch, failed testing.

RainbowArray’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.