Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules
3 occurrences of the word "enabl". Might not need to change all 3. Please check if the occurrence in BreakpointThemeTest.php needs to be changed.
1 occurrence of the word "disabl". Might not need to be changed Please check.
Comment | File | Size | Author |
---|---|---|---|
#12 | change_enabl_to_install_disabl_to_uninstall-2318801-12.patch | 469 bytes | jarsenx |
#5 | change_enabl_to_install_disabl_to_uninstall-2318801-5.patch | 925 bytes | jarsenx |
Comments
Comment #1
xjmComment #2
jarsenx CreditAttribution: jarsenx commentedThree occurrences of the word "enable"
Recommend changing the first two to read "* Modules to install."
Third does not need to change.
One occurrence of the word "disable"
Does not need to change
Comment #3
jarsenx CreditAttribution: jarsenx commentedComment #4
jarsenx CreditAttribution: jarsenx commentedComment #5
jarsenx CreditAttribution: jarsenx commentedPatch change_enabl_to_install_disabl_to_uninstall-2318801-4.patch is ready for review.
Comment #6
jarsenx CreditAttribution: jarsenx commentedComment #7
jarsenx CreditAttribution: jarsenx commentedComment #10
RainbowArrayNeeds a reroll, but patch is still relevant. Should be an easy fix.
Comment #11
RainbowArrayOops. I was looking at Alpha 12. This fix is no longer needed due to #2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level.
Comment #12
jarsenx CreditAttribution: jarsenx commentedRecreated patch for enable/disable issue.
Comment #13
mbrett5062 CreditAttribution: mbrett5062 commentedI have downloaded latest 8.0.x-dev and searched within core/modules/breakpoint for "enabl" and "disabl".
Here are results
Found only the one instance of "Module - enable"
As far as I can see this issue/patch is good to go.
Comment #14
mbrett5062 CreditAttribution: mbrett5062 commentedSetting to RTBC as per comment #13 above.
Comment #16
mbrett5062 CreditAttribution: mbrett5062 commented@webchick, sorry if I am completely wrong here, but should this not have been moved to status "Fixed" before committing? Will the automated issue queue thing pick this up and close after 2 weeks if it is not set to fixed?
Ignore me if I am being silly, I know nothing, and very well I might say.
Comment #18
RainbowArray