D7 When entity_translation is enabled tagclouds displays terms of other languages in block even if tagclouds_language_separation is enabled

To test this patch:

1. enable entity translation if it isn't already (or use a distro like this)
2. create taxonomy vocabulary with translation mode "Translate." enabled (Different terms will be allowed for each language and they can be translated.)
3. add taxonomy term reference field to basic page content type
   (options: use autocomplete widget)
   (more options: enable translation on taxonomy term reference field)
4. install and enable tagclouds
5. enable "Separation of Tags per language" in eng/admin/config/content/tagclouds
6. add tagclouds block to a panel or page
7. add new basic page , add two taxonomy terms to your autocomplete taxonomy term reference field "taxonomy1-eng, taxonomy2-eng"
8. translate the same basic page (entity translation so the same "entity id /node id") , add terms "taxonomy1-lang2, taxonomy2-lang2"
9. add a second basic page, and translate it as done in step 7 and step 8, (use same taxonomy (tag) names "taxonomy1-eng, taxonomy2-eng" for english and "taxonomy1-lang2, taxonomy2-lang2" for the "other " language
10. compare results, you should see tag clouds for both english and lang2

Now, this patch works great most of the time. There are some edge cases though. It just so happens that some words are the same accross different languages. For instance the word "corruption" is the same in English as it is in French, for these cases the condition in the query should not be using taxonomy_index table it should be using the field_data_field_xyz field_xyz_tid.language instead of td.language in the join. However this will require some UI work and some more stuff on the other end. The attached patch is far better than what the current implementation is (for entity_translation) but a more graceful solution should be attempted in a new issue, I'll create a new issue for that and reference this one.

Enhancement for the patch: the content type in question should be checked for the translation type rather than a simplistic check exists on entity_translation . This will be more accurate especially for D8 as entity_translation is part of core in D8 but also work better for D7 as well.

The patch was modified to add a radios button and committed directly into dev and into 7.x-1.10

See release notes for 7.x-1.10 and also see readme.txt for how to use and also see source code if you really want to know more.

Hi PascalAnimateur, your work looks great at first glance and it sounds reasonable. I'm going to take a passive stance on this and hope that someone from the community can provide some evaluation(s).

Looking for some community evaluations.

Hi Martin, we should probably get this into 8.x before committing it to 7.x

since you're working on 8.x, I'm assigning this to you.

I haven't had time to test this patch, but if one other person reviews it and tests it and marks this RTBC then I'll commit it.

Thanks,

The CI error will be fixed once we add a simpletest for tagclouds .. Start with a very basic one that just checks that the module installs correctly.

here's the related issue for fixing the CI error
#2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present

Sorry I haven't had much time for tagclouds lately

If someone can please create a very basic simpletest that just checks that the module installs correctly then I'll commit this as it looks good.

we may also have to update the readme.