When using the PDF Table display, my table headers (ie the labels of my fields) are printed 2 times. I will provide a patch to fix this issue.

CommentFileSizeAuthor
#7 views_pdf_table_header_double_labels-2270233-7.patch666 bytescalmforce
#1 2270233-table_header-1.patch1.04 KBguillaumev

Comments

guillaumev’s picture

guillaumev commented
Status: Active » Needs review
StatusFileSize
new 2270233-table_header-1.patch1.04 KB

Here is the patch.

stefank’s picture

stefank commented

I can confirm that the patch works. Anybody else had a chance to test it, so we can move to RTBC?

thanks

stefank’s picture

stefank commented
Status: Needs review » Reviewed & tested by the community

Actually its a small change so let put it to RTBC.

killua99’s picture

killua99 commented
Assigned: Unassigned » vegansupreme
Status: Reviewed & tested by the community » Needs work

I'll take a look.

@vegansupreme can you do the same if you have time. (assigned for email ping, you know that :) )

vegansupreme’s picture

vegansupreme commented

This patch does work at preventing the table header from being printed two times, however you can no longer apply a class to the label. Normally, in the label field you could put something like <span class="top">theTitle</span> and then you could use CSS to style it. Before applying this patch I could use CSS to change the color of the label using a class. After applying the patch, the color was gone. This only applied to the labels, the fields were fine.
Using <em>theTitle</em> still works though.
I'm not sure how to fix this patch, or if it even needs to be fixed. Just pointing out an issue I found.

killua99’s picture

killua99 commented
Assigned: vegansupreme » Unassigned

Ok thanks ... looks like need some work.

calmforce’s picture

calmforce commented
StatusFileSize
new views_pdf_table_header_double_labels-2270233-7.patch666 bytes

I made the simple fix in the current dev version - modified line 710 in views_pdf_template.php by replacing TRUE to FALSE, and now the header looks right. The patch is attached.

vegansupreme’s picture

vegansupreme commented
Status: Needs work » Needs review

#7 works for me, without the problems I mentioned in #5

killua99’s picture

killua99 commented

if @guillaumev @stefank can review this will be nice.

@vegansupreme already did so if in one week isn't reviewed for anyone else, we submit this patch and make the v1.4 official.

Sound like a plan?

stefank’s picture

stefank commented

Yeah, the #7 works for me as well.

vegansupreme’s picture

vegansupreme commented
Status: Needs review » Fixed

Committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.