Closed (fixed)
Project:
Juicebox HTML5 Responsive Image Galleries
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Mar 2014 at 04:43 UTC
Updated:
23 Oct 2014 at 03:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rjacobs commentedIt looks like drupal.org automatically links commits with the issue queues, neat.
The commit adds a whole bunch of tests. These all pass fine in a dev space, but the drupal.org testbots may be a whole other story. Adding a bogus patch here to test the new tests.
Comment #3
rjacobs commentedHummm, it looks like the tests were actually triggered on the commit (https://qa.drupal.org/pifr/test/664058). There were a few failures, but the bulk of the test structures seem to be alright. The failures may related to the image style handling or maybe something to do with URL structures.... I'll need to look into that.
The "test patch" will probably be postponed for testing until that's worked out.
Comment #5
rjacobs commentedThis turned out to be an issue with clean URLs. Some assumptions were set to detect clean URL structures (or unencoded attributes), which worked locally but not with the testbot. Everything passes now.
The only pending issue is that it looks like one of the tests cases is getting skipped (JuiceboxFileEntityCase). According to the logs (https://qa.drupal.org/pifr/test/664058), that test case is "found", but it's not run... no explanation why. That test case does have a file_entity dependency, so there might be something odd with the handling of that.
Comment #6
rjacobs commentedI posted an issue in the testbot queue about the bypassed test case: #2226577: Test case skipped without explanation (works locally), may be related to file_entity contrib dependency.
Comment #7
rjacobs commentedHere's a patch which removes the 'dependencies' key from the getInfo() details for the test that uses file_entity. My guess is that this could what keeps testbot from even trying this test case. It's seems that testbot must have some awareness of the file_entity project because that projects own tests get run on drupal.org.
This is just for experimentation to see if the test logs come back any different.
Comment #9
rjacobs commentedWell, that got it to try the test case, so that's useful. Of course it failed to install file_entity, so the test died in a streak of blue flames.
This makes me wonder how it is that file_entity's own test manage to run.
Comment #10
rjacobs commentedI think the issue with file_entity is fixed now. It turn out that adding
'dependencies' => array('file_entity')to getInfo() is not enough. It looks like that does make the dependency available, it just deactivates the test if the dependency is not available.To truly make the dependency available one needs to either enable a helper test module that declares the dependency in its .info file, or use the
test_dependencies[]line in the main module's .info file. I just added this to juicebox.info:test_dependencies[] = file_entityAnd thing seem to work.
Re-submitting the bogus patch to confirm 100%
Comment #11
rjacobs commented516 passes > 464 passes... so that now accounts for the file_entity case. Finally.
Ok, now this needs attention in 8.x-2.x
Comment #12
rjacobs commentedHere's a partial port of the D8 tests for the field formatter. I just want to see how these behave with the testbot.
Comment #14
rjacobs commentedHummm, here's another with just setup logic.
Comment #16
rjacobs commentedComment #18
rjacobs commentedDue to the libraries API dependency, it's possible that this won't work with D8 testbots until #2047557: Support Drupal 8-style *.info.yml files is addressed. This needs more investigation I guess.
Comment #19
rjacobs commentedActually, it looks like I had a case issue with a class name (totally unrelated to the actual test logic) which somehow was swallowed by my local php. Trying again.
Comment #20
rjacobs commentedOk, finally, the base test port works with testbots. Now I just have to finish porting the rest of the tests.
Comment #21
rjacobs commentedAbout 2/3 ported. Here's another one to test the testbot.
Comment #22
rjacobs commentedMissed a file....
Comment #23
rjacobs commentedHere's a complete set of tests for the global features and field formatter.
Comment #25
rjacobs commentedOk, that's finally committed. Tests for views are pending because views support has not been ported yet. Those tests can be added as part of #2188157: D8 port views style plugin.