#2152073: Bump Drupal core's PHP requirement to 5.4.2 just got committed. Yay!

In addition to the PHP Mail stuff that had to be backed out during commit, we should look for other places where we're referencing old PHP 5.3 and below stuff and remove that too.

This may have to be a meta issue; not sure how much there is.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Status: Active » Needs review
FileSize
2.47 KB

Rerolled with git rebase, which automatically moved the the PhpMail stuff to the new location.

Mixologic’s picture

Found another example of safe_mode checking in ArchiveTar.php

tim.plunkett’s picture

Status: Needs review » Needs work
+++ b/core/lib/Drupal/Component/Archiver/ArchiveTar.php
@@ -182,7 +182,7 @@ function loadExtension($ext)
-            if ((ini_get('enable_dl') != 1) || (ini_get('safe_mode') == 1)) {
+            if (ini_get('enable_dl') != 1) {

This is Component code, we shouldn't change it. See #1298304: [Meta] Move all externally-developed files to core/vendor/{vendorname}/ directories

Mixologic’s picture

Every few months, however, someone comes along and submits an issue to apply current coding standards to these files, which wastes time and energy for all concerned.

Oops. Thanks, I had assumed that everything was already under the vendor directories.

Is there any risk of running into 5.3 code that would actually fatal under 5.4 in any of the Component or vendor directories? This was the only thing revealed by a phpstorm language level inspection of the whole codebase, so my hunch/belief is that there shouldn't be any problems.

Mixologic’s picture

Also, apparently the file in question isnt *totally* a component.

#1669896: Please clarify status of ArchiveTar.php

Les Lim’s picture

Status: Needs work » Reviewed & tested by the community

#1 is RTBC, in any case.

effulgentsia’s picture

Status: Reviewed & tested by the community » Needs work

Thanks. But:

1) Let's reupload #1 to make sure it's the most recent one so that a core committer doesn't accidentally commit the wrong one.
2) The patch does less than what the issue title and summary say. Let's either continue to add more to it, or else if we want this committed on its own, retitle and resummarize this issue and open a new meta to track what else there is.

sun’s picture

Title: Clean up dead PHP 5.3-only code » Remove legacy PHP 5.3 code from PhpMail plugin
Status: Needs work » Reviewed & tested by the community
Issue tags: +PHP BC cleanup

If there's any sensible use-case for hiding attached issue files at all, then I guess this is it. And to be extra sure:

Patch to commit is #1

Adjusting issue title accordingly. Adding new "PHP BC cleanup" issue tag, because it does not make sense to attack all affected code in a single issue/patch.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed #2 to 8.x. Thanks!

Kidding. :P #1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.