Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#2152073: Bump Drupal core's PHP requirement to 5.4.2 just got committed. Yay!
In addition to the PHP Mail stuff that had to be backed out during commit, we should look for other places where we're referencing old PHP 5.3 and below stuff and remove that too.
This may have to be a meta issue; not sure how much there is.
Comment | File | Size | Author |
---|---|---|---|
#1 | php53-mail-2207021-1.patch | 2.47 KB | Berdir |
Comments
Comment #1
BerdirRerolled with git rebase, which automatically moved the the PhpMail stuff to the new location.
Comment #2
MixologicFound another example of safe_mode checking in ArchiveTar.php
Comment #3
tim.plunkettThis is Component code, we shouldn't change it. See #1298304: [Meta] Move all externally-developed files to core/vendor/{vendorname}/ directories
Comment #4
MixologicOops. Thanks, I had assumed that everything was already under the vendor directories.
Is there any risk of running into 5.3 code that would actually fatal under 5.4 in any of the Component or vendor directories? This was the only thing revealed by a phpstorm language level inspection of the whole codebase, so my hunch/belief is that there shouldn't be any problems.
Comment #5
MixologicAlso, apparently the file in question isnt *totally* a component.
#1669896: Please clarify status of ArchiveTar.php
Comment #6
Les Lim#1 is RTBC, in any case.
Comment #7
effulgentsia CreditAttribution: effulgentsia commentedThanks. But:
1) Let's reupload #1 to make sure it's the most recent one so that a core committer doesn't accidentally commit the wrong one.
2) The patch does less than what the issue title and summary say. Let's either continue to add more to it, or else if we want this committed on its own, retitle and resummarize this issue and open a new meta to track what else there is.
Comment #8
sunIf there's any sensible use-case for hiding attached issue files at all, then I guess this is it. And to be extra sure:
Patch to commit is #1
Adjusting issue title accordingly. Adding new "PHP BC cleanup" issue tag, because it does not make sense to attack all affected code in a single issue/patch.
Comment #9
webchickCommitted and pushed #2 to 8.x. Thanks!
Kidding. :P #1.