Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Currently a condition's config form wrapper is only uniquely identified by the generated element id. This is not suitable to use in CSS selectors as it contains the $delta in the "id".
My proposed fix is to add the $condition_name to the container-inline element as a CSS class.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | inline_conditions-condition_name_css_class-2204733-4.patch | 714 bytes | jkuma |
| #2 | inline_conditions-condition_name_css_class-2204733-2.patch | 815 bytes | cravecode |
Comments
Comment #1
cravecode CreditAttribution: cravecode commentedThe patch is pretty noninvasive and uses Drupal's
drupal_clean_css_identifierfunction on the$condition_namevariable to append to the container element's CSS classes.Comment #2
cravecode CreditAttribution: cravecode commentedCorrected spacing between
clearfixand the appended$condition_nameComment #3
jkuma CreditAttribution: jkuma commentedThanks for your patch cravecode, I'll take a look at it this afternoon.
best, jo
Comment #4
jkuma CreditAttribution: jkuma commentedYour patch was not working because the "$condition_name" variable doesn't exists at this level.
I've made an another patch to solve your issue.
Comment #6
jkuma CreditAttribution: jkuma commentedComment #7
jkuma CreditAttribution: jkuma commented4: inline_conditions-condition_name_css_class-2204733-4.patch queued for re-testing.
Comment #8
jkuma CreditAttribution: jkuma commentedCommit pushed in dev branch.