In admin/reports/status, CKEditor is listed in red as "too old, please install CKEditor 4.2+" when the source version from CKBuilder is used.
Upon switching to the optimized version, things go back to normal.

EDIT: required version reported was 4.2 instead of 4.1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Thanks for the report, I'll look into this.

Wim Leers’s picture

Category: Bug report » Support request
Status: Active » Postponed (maintainer needs more info)

Actually, Edit lets ckeditor.module do all the hard work of figuring out which version is being used. Plus, the requirement is "4.2 or newer", not "4.1+".

So I'm not quite sure what's happening. Can you post a screenshot of your status report page? Thanks!

jbeckers’s picture

Title: CKEditor reported as "incompatible, please install 4.1+" when downloading source zip from CKBuilder » CKEditor reported as "too old, please install 4.2+" when downloading source zip from CKBuilder
Issue summary: View changes
FileSize
82.63 KB
Wim Leers’s picture

Can you also post a screenshot of the "CKEditor" row in the Status report?

jbeckers’s picture

Aha, that line says "git version"

jbeckers’s picture

FileSize
10.37 KB
Wim Leers’s picture

There you go. That's why Edit is complaining in the status report. I don't think there's anything I can do about this, then…

Wim Leers’s picture

Assigned: Unassigned » Wim Leers
Status: Postponed (maintainer needs more info) » Fixed
Issue tags: +Spark

In other words: you can just ignore this failure. If you're using the GIT version, you're supposed to know what you're doing, I guess :)

jbeckers’s picture

The thing is, I'm not using the git version on purpose. It seems that http://ckeditor.com/builder outputs a git version when you select "Source (Big N’Slow)", even though the big orange button reads "Download CKEditor 4.3.1".

So yeah, nothing Edit can fix.

Wim Leers’s picture

Status: Fixed » Active

I've asked the CKEditor folks to chime in. Maybe there *is* something Edit can do. But I doubt it. Even if there is, it's probably not worthwhile because >95% (if not >99%) will not download the "Source (Big N’Slow)" version.

wwalc’s picture

In ckeditor.install there is a code that displays the CKEditor version in "Status report", it looks like this:

      if ($installed_version == '%VERSION%') {
        $requirements['ckeditor']['value'] = 'GIT version';
      }

Edit does a simple version compare:

      if (version_compare($ckeditor_version, '4.2.0') == -1) {
        $requirements['edit_libraries_ckeditor']['value'] = t('The CKEditor library is too old, please update to 4.2 or newer!');
        $requirements['edit_libraries_ckeditor']['severity'] = REQUIREMENT_ERROR;
      }

which means that it cannot handle the "Source (Big N’Slow)" version, but also any version downloaded straight from the GIT repository, from any development branch. You should treat the "Source (Big N’Slow)" release just like any other distribution taken straight from the GIT repository (both will have version: '%VERSION%').

I'd suggest changing the message for such users into something like:

You are using the source version of CKEditor at your own risk, in case of using an outdated version some things may not work as expected. The latest stable version of CKEditor (an optimized release version) is recommended.

Wim Leers’s picture

Title: CKEditor reported as "too old, please install 4.2+" when downloading source zip from CKBuilder » Warn about using the "Source (Big N’Slow)" version of CKEditor in the Status Report
Category: Support request » Task
Status: Active » Fixed
FileSize
11.45 KB

Alright, added a check for this in the status report as well:

http://drupalcode.org/project/edit.git/commit/9e2fd9e

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.