Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Updated: Comment #0
Problem/Motivation
sun rightfully complained in #1996238: Replace hook_library_info() by *.libraries.yml file that the CKEditor module's library definitions contain a setting that is dynamically generated, which violates the immutability principle of libraries.
While working on removing this, I noticed that this was not being used at all.
Worse: the original commit of ckeditor.module shows that it was never used!
Proposed resolution
Get rid of it. Good riddance!
Remaining tasks
None.
User interface changes
None.
API changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | ckeditor_library_dynamic_setting-2161759-1.patch | 929 bytes | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
nod_(deadcode--)++ or something :D
That works.
Comment #3
sunIf possible, it would be great to defer these commits on #1996238: Replace hook_library_info() by *.libraries.yml file, because that one is an utter pain to re-roll.
Comment #4
Wim Leers#3 is not yet ready, and it allows you to simply *remove* several hunks from that patch, so I respectfully disagree.
Comment #5
webchick#1996238: Replace hook_library_info() by *.libraries.yml file was already broken by it looks like many other things, so will need a re-roll in any event. Getting this one in in the meantime.
Committed and pushed to 8.x. Thanks!
Comment #6
Wim Leers