There's no reason to have dollar signs in the salsa entity text.

The currency is country specific.

CommentFileSizeAuthor
#1 salsa_entity_currency_2160829.patch1.39 KBmiro_dietiker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker commented
Status: Active » Needs review
FileSize
salsa_entity_currency_2160829.patch1.39 KB

Attached patch should fix it.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

This is modelled after the salsa forms, which have the same label. salsa_commerce AFAIK replaces it with the default currency or remove it. Or so I thought.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker commented

It seems not to be replaced correctly then.

Move to salsa_commerce queue then?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

1: salsa_entity_currency_2160829.patch queued for re-testing.

s_leu’s picture

s_leu CreditAttribution: s_leu commented
Status: Needs review » Reviewed & tested by the community

Looks and reads like RTBC to me

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Let's commit it for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.