Updated: Comment #N

Problem/Motivation

Views exposed forms got slightly broken along the way somewhere. Currently, you cannot change the value of the submit button (You can see this already by looking at the admin/content view, the exposed filters button says 'Apply' when this should say 'Filter', which is in the configuration for the view), also the reset button is not nested inside the actions for the form.\\

Before:

before

After:

after

Proposed resolution

Fix these issues and add test coverage for the submit button!

Remaining tasks

Patch, review.

User interface changes

Reset button moved to the correct part of the form, submit button shows the correct value.

API changes

None.

CommentFileSizeAuthor
#15 interdiff-2149751-15.txt745 bytesdamiankloip
#15 2149751-15.patch7.16 KBdamiankloip
#9 interdiff-2149751-7.txt1.51 KBdamiankloip
#9 2149751-7.patch7.15 KBdamiankloip
vdc.submit-label-PASS.patch7.15 KBdamiankloip
vdc.submit-label-FAIL.patch5.43 KBdamiankloip
Screenshot 2013-12-04 15.13.46.png18.29 KBdamiankloip
Screenshot 2013-12-04 15.14.14.png14.78 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue summary: View changes
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue summary: View changes
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue summary: View changes
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, vdc.submit-label-PASS.patch, failed testing.

The last submitted patch, vdc.submit-label-FAIL.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
2149751-7.patch7.15 KB
interdiff-2149751-7.txt1.51 KB

Use the Views class..

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

vdc.submit-label-FAIL.patch queued for re-testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

vdc.submit-label-PASS.patch queued for re-testing.

The last submitted patch, vdc.submit-label-FAIL.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.php
@@ -181,8 +181,19 @@ public function preExecute() { }
+   * @param $form
+   *   The form build array. Passed by reference.
+   * @param $form_state
+   *   The form state. Passed by reference.

I thought we don't have to document that, but I don't care.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Thanks! I thought better to document anyway, as it's not a form alter in the regular place.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
2149751-15.patch7.16 KB
interdiff-2149751-15.txt745 bytes
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

The last submitted patch, 15: 2149751-15.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

15: 2149751-15.patch queued for re-testing.

The last submitted patch, 15: 2149751-15.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.