Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The _dart_add_key_val() function can be called many times on a single page load resulting in potentially expensive calls to token_replace().
In order to avoid repeat executions the results of token_replace() could be statically cached. Patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2118653-3-dart-add_key_val_performance.patch | 895 bytes | elliotttf |
| #1 | 2118653-1-dart-add_key_val_performance.patch | 988 bytes | elliotttf |
Comments
Comment #1
elliotttf CreditAttribution: elliotttf commentedFWIW, this patch reduced execution time in
_dart_add_key_val()by about 1.3 seconds on the site I'm working with right now.Comment #3
elliotttf CreditAttribution: elliotttf commentedDerp, here's a fixed patch that should pass tests.
Comment #4
bleen CreditAttribution: bleen commentedfixed: http://drupalcode.org/project/dart.git/commit/7cf25a5