Original keys might be an array, too [#2117613]

In the service class's preQuery() method, you use $keys = $query->getOriginalKeys(); to retrieve the unparsed keys, so you can lowercase them if necessary.
However, the original keys might already be an array – they are what is passed to the query's keys() method, and already parsed keys are allowed there.

You should therefore at least check if the return value is really a string before using preg_match on it.

Comment	File	Size	Author
#1	2117613-1--original_keys.patch	866 bytes	drunken monkey
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

drunken monkey

he/him

German

Vienna, Austria

CreditAttribution: drunken monkey commented 22 October 2013 at 12:29

Status:

Active

» Needs review

File	Size
2117613-1--original_keys.patch	866 bytes

Patch attached.

Comment #2

Nick_vh

he/him

Ghent

CreditAttribution: Nick_vh commented 12 March 2014 at 13:50

Issue summary:	View changes
Status:	Needs review	» Fixed

git commit -m "Issue #2117613 by drunken monkey: Original keys might be an array, too." --author="drunkenmonkey <drunkenmonkey@205582.no-reply.drupal.org>"
[7.x-2.x d31c814] Issue #2117613 by drunken monkey: Original keys might be an array, too.
 Author: drunkenmonkey <drunkenmonkey@205582.no-reply.drupal.org>
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks! Committed