Hello.
This is the best module for password a node. It's effective, customisable, simple and the most powerful.
I need this module and I'm using it in a public environment website with D7.
I know the D7 version of the module it's only for development but I couldn't found another module so simple and customisable like this one, so we're taking the risks of using it.

So far I didn't found any issues but would like to ask a review and if it's possible to release a RC version to implement in public envirments.
Thanks

Comments

anybody’s picture

Issue summary: View changes

It would be great to have such a release, that can also be translated on localize.drupal.org.

Currently only D6 Versions are avaliable there due to this issue and that makes translation impossible there.

izus’s picture

Hello,
le D7 dev version still have some D6 legacy code that needs cleanup and it is not well tested yet, that introduced regressions each time there is a new patch and there are a lot of cases to test.

Thats why we focus currently on #2277045: Implement tests for protected node
The private files protection has also a lot of legacy code and needs to work correctly and have tests, efforts for this are in #2179473: Protected Node Denies Private File Access

I belive these two issues should be fixed before a release candidate. Many regressions were experienced here and there and thus it's very important to have tests and to run them against every single patch.

Please feel free to help on those 2 issues, this module needs more contributors !

Thanks

damienmckenna’s picture

Title: Release a public candidate to use in D7 » [META] Plan for Protected Node v7.x-1.0 release
Component: Code » Miscellaneous
Category: Support request » Task

Standardized the subject line, and this is a task.

grimreaper’s picture

Hello,

Now that the issues are closed, can we make the tag 7.x-1.0 ?

Or as this module restricts the access with passwords and therefore there is an information leak risk, should we need to wait for a security review or an approval?

izus’s picture

i guess we should probably start with some rc or beta versions,
we should also search /ask in irc if we can have some security review by security team or if it's not possible do a final security code reading.
if you find sth related to that please drop a line, i'll do the same.

izus’s picture

i suggest we publish an rc for one month at least
meanwhile a poc for d8 can maybe be started
what do you think of it ?

digitgopher’s picture

All child issues closed, time for a release?

izus’s picture

yeah, rc1 for a month, i would say
with no *bugs* discovered or *security* issues ()=> 1.0 :)
but we shouldn't add new features to same branch (only docs and fixes)

grimreaper’s picture

If everyone is ok, I will make a tag 7.x-1.0-rc1

anybody’s picture

+1 @Grimreaper

izus’s picture

@Grimreaper : go for it !

digitgopher’s picture

+1 to #8/#9

  • Grimreaper committed 446a543 on 7.x-1.x
    Issue #2105245 by Grimreaper: Fix pareview.sh errors.
    
grimreaper’s picture

Status: Active » Needs review

Release created: https://www.drupal.org/node/2565233

Thanks everyone.

izus’s picture

Now that there is a critical bug, we have to wait until it's fixed and release rc2
rc2 = all criticals of rc1 commits + all commits of "small fixes"
1.0 release = rc2 + 1 month of no criticals
do you agree @Grimreaper ?

List of criticals : https://www.drupal.org/project/issues/protected_node?priorities=400

grimreaper’s picture

Hello Izus,

Agreed :).

I am applying, testing and merging patches.

grimreaper’s picture

Hello,

And here is the 7.x-1.0-rc2 release: https://www.drupal.org/node/2575907

grimreaper’s picture

Status: Needs review » Fixed

Hello,

More than a month has passed without new bugs.

So here comes the stable release: https://www.drupal.org/node/2605758

Thank you very much everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.