Closed (fixed)
Project:
Protected Node
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Oct 2013 at 00:08 UTC
Updated:
15 Nov 2015 at 09:34 UTC
Jump to comment: Most recent
Comments
Comment #1
anybodyIt would be great to have such a release, that can also be translated on localize.drupal.org.
Currently only D6 Versions are avaliable there due to this issue and that makes translation impossible there.
Comment #2
izus commentedHello,
le D7 dev version still have some D6 legacy code that needs cleanup and it is not well tested yet, that introduced regressions each time there is a new patch and there are a lot of cases to test.
Thats why we focus currently on #2277045: Implement tests for protected node
The private files protection has also a lot of legacy code and needs to work correctly and have tests, efforts for this are in #2179473: Protected Node Denies Private File Access
I belive these two issues should be fixed before a release candidate. Many regressions were experienced here and there and thus it's very important to have tests and to run them against every single patch.
Please feel free to help on those 2 issues, this module needs more contributors !
Thanks
Comment #3
damienmckennaStandardized the subject line, and this is a task.
Comment #4
grimreaperHello,
Now that the issues are closed, can we make the tag 7.x-1.0 ?
Or as this module restricts the access with passwords and therefore there is an information leak risk, should we need to wait for a security review or an approval?
Comment #5
izus commentedi guess we should probably start with some rc or beta versions,
we should also search /ask in irc if we can have some security review by security team or if it's not possible do a final security code reading.
if you find sth related to that please drop a line, i'll do the same.
Comment #6
izus commentedi suggest we publish an rc for one month at least
meanwhile a poc for d8 can maybe be started
what do you think of it ?
Comment #7
digitgopher commentedAll child issues closed, time for a release?
Comment #8
izus commentedyeah, rc1 for a month, i would say
with no *bugs* discovered or *security* issues ()=> 1.0 :)
but we shouldn't add new features to same branch (only docs and fixes)
Comment #9
grimreaperIf everyone is ok, I will make a tag 7.x-1.0-rc1
Comment #10
anybody+1 @Grimreaper
Comment #11
izus commented@Grimreaper : go for it !
Comment #12
digitgopher commented+1 to #8/#9
Comment #14
grimreaperRelease created: https://www.drupal.org/node/2565233
Thanks everyone.
Comment #15
izus commentedNow that there is a critical bug, we have to wait until it's fixed and release rc2
rc2 = all criticals of rc1 commits + all commits of "small fixes"
1.0 release = rc2 + 1 month of no criticals
do you agree @Grimreaper ?
List of criticals : https://www.drupal.org/project/issues/protected_node?priorities=400
Comment #16
grimreaperHello Izus,
Agreed :).
I am applying, testing and merging patches.
Comment #17
grimreaperHello,
And here is the 7.x-1.0-rc2 release: https://www.drupal.org/node/2575907
Comment #18
grimreaperHello,
More than a month has passed without new bugs.
So here comes the stable release: https://www.drupal.org/node/2605758
Thank you very much everyone!