Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Background:
This issue is part of the task to update the hook_help texts of the Drupal 8 modules:
#1908570: [meta] Update or create hook_help() texts for D8 core modules
Tasks:
- review / write the hook_help text according to help guidelines
Comment | File | Size | Author |
---|---|---|---|
#14 | drupal8.book-module.2091385-14.patch | 4.81 KB | lostkangaroo |
#14 | interdiff.txt | 1.3 KB | lostkangaroo |
#8 | book-2091385-8.patch | 4.8 KB | batigolix |
#8 | diff.txt | 2.36 KB | batigolix |
#5 | book-2091385-5.patch | 5.11 KB | dietmarg |
Comments
Comment #1
tankerjoe CreditAttribution: tankerjoe commentedThe text for the hook_help looks good in my opinion, however the url() calls needed to be updated to the drupal-8 style. This patch does that.
Comment #2
lostkangaroo CreditAttribution: lostkangaroo commentedone small thing, the tokens for routes should use ! rather than @
Comment #3
batigolixPatch changes '@link' to '!link'
Comment #4
lostkangaroo CreditAttribution: lostkangaroo commentedThis sentence seems like it could use a touch of reengineering from a word smith.
You can assign separate permissions for creating, editing, and deleting book content, as well as adding content to books, and creating new books.
Other than that everything seems to be in order and receives a passing grade.
Comment #5
dietmarg CreditAttribution: dietmarg commentedChanged sentence from #4 to
Comment #6
lostkangaroo CreditAttribution: lostkangaroo commentedExcellent, the permissions section reads much easier and all the technical bits are working as intended. Good Work everyone!
Comment #7
alexpottThis looks wrong
<em>creating new books</em> as well as<em>creating</em>
no space between as and creating.Comment #8
batigolixpatch:
- fixes #7
- changes http:// to https://
Comment #9
batigolixunassign
Comment #10
lostkangaroo CreditAttribution: lostkangaroo commentedJust manually reviewed the patch and it is good to go as far as this issue is concerned. I did find an issue #2112237: Regression: Remove EntityFormControllerNG from book module, but this does not block this task since the page exists, it is only sick for the time being.
Comment #11
webchickProbably makes sense for Jennifer to give this a sign-off.
Comment #12
jhodgdonSorry, I apparently missed this one!
In About, the reference to the online docs is not following our current template.
Other than that, this looks good!
Comment #13
jhodgdonComment #14
lostkangaroo CreditAttribution: lostkangaroo commentedFixed the online docs link
Comment #15
lostkangaroo CreditAttribution: lostkangaroo commentedComment #16
batigolixPatch applies, links are okay and text is conform the guidelines
Comment #17
jhodgdonThanks for the new patch and quick review! Agree this is ready to commit.
Comment #18
jhodgdonThanks all! Committed to 8.x.