Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Related to inline_conditions
I have reworked a bit the form structure's CSS.
(see caption)
Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Related to inline_conditions
I have reworked a bit the form structure's CSS.
(see caption)
Comments
Comment #1
cookiz commentedComment #2
bojanz commentedWhy is offer type below conditions now?
It always made sense to me for offer type to be below discount type.
Other than that, huge +1 for the changes.
Comment #3
jkuma commentedBojan,
This approach has been modeled after the rules module. From my perspective, It's more logic to first tackle the "discount problem => discount type + conditions" (What is the target of my discount ?) and after select the offer type (What kind of discount do I want ?). But maybe I'm wrong, nevertheless we definitely need inputs from UX/UI guys on that subject....
And by the way, thank you so much cookiz for your rework of commerce_discount UI.
Comment #4
cookiz commentedAnother patch is coming handling RTL support :)
Comment #5
cookiz commentedThis patch will required 1 patch for inline_conditions to be accepted https://drupal.org/node/2026913#comment-7573169
Comment #6
cookiz commentedOops, I've forgotten to cleanup a bit the rtl scss/css file before pushing..
Comment #7
cookiz commentedNew patch, I've rewamp a bit the css:
- separate scss files from css (create new folder "scss" and move the files into)
- import css code from inline_conditions which were only related to commerce_discount...
- clean up code
Comment #8
cookiz commentedAdded a fix for commerce_discount_usage in RTL..
Comment #9
jkuma commentedLooks good to me and the patch is working well.
Comment #10
jkuma commentedCommitted in 7.x-1.x-dev branch.
Comment #17
joelpittet