Using a token to a field which may be empty results in an ugly printing of the token description like [node:author:field_…].
Please change this to: A token to a field should print nothing if there no content in the field.

CommentFileSizeAuthor
#1 2021355.patch934 bytesnancydru

Comments

nancydru’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new934 bytes

It was a conscious choice, but give this a try.

tkuldeep17’s picture

hi @kbi,

Thanks for pointing out.
@NancyDru. Your patch is working fine. It should be ported into code. If I get access to push to this project, I will commit this patch to code..

nancydru’s picture

Assigned: Unassigned » nancydru

You have access now.

  • tkuldeep17 committed f04f43b on 7.x-1.x
    Issue #2021355 by kbi,NancyDru,tkuldeep17: Fix emtpy token problem.
    
tkuldeep17’s picture

Status: Needs review » Closed (fixed)

Closing it, as it has now fixed.

nancydru’s picture

Status: Closed (fixed) » Fixed

Kuldeep, there are a couple of things to mention here.

1) Just mark the issue "Fixed", not "Closed". The system will mark it closed in two weeks. This gives people time to find it.

2) When you commit, you should use GIT attribution. You can find the format on each user's page. It will be something like --author="nancyw <nancyw@101412.no-reply.drupal.org>". This gives them credit which shows their level of involvement in the community.

3) You need only mention those directly involved in creating the patch; in this case that would be only me.

tkuldeep17’s picture

Thanks NancyDru for above points. I will follow these guidelines.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.