Closed (fixed)
Project:
Doubleclick for Publishers (DFP)
Version:
7.x-1.0
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Jun 2013 at 21:11 UTC
Updated:
6 Dec 2014 at 13:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
evanjenkins commentedHere is the patch!
Comment #2
bleen commentedwhite spaces
... is there a way we can write a simpletest for this? If you add "test_dependencies[] = panels" then testbot will know to include panels when running tests
Comment #3
tom friedhof commentedHere is the same patch from #1 with the exception of explicitly declaring what plugins this module implements. I was getting Fatal Errors when ctools read the contexts plugins into memory because it was looking for a Class in a module not enabled on the site I'm working on. (Context module)
The context integration should probably be broken out into a separate module, since that module isn't necessarily needed to use this module, especially with this panels integration. That's a topic for another discussion.
Comment #4
bleen commentedIf anyone has used the patch in #3 and can post an "it works" review that would be great. Other than some minor white space issues, I'd be willing to bring this in...
Comment #6
bleen commentedFixed (except I changed the of the form element to 'dfp_ads' instead of 'cehck_ads'
Comment #7
bleen commented