Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Diff module breaks layout for fixed width themes. If a line is too long, it will expand the comparison area. Wikipedia has a solution to this problem, which I've ported to Diff in the attached patch.
Comment | File | Size | Author |
---|---|---|---|
#3 | diff_layout_fix.patch | 3.28 KB | moonray |
diff_layout_fix.patch | 3.75 KB | moonray |
Comments
Comment #1
moonray CreditAttribution: moonray commented(That's supposed to be under Diff, not Revision Moderation)
Comment #2
dwwWithout looking closely, this seems to introduce an XSS bug:
Why is this change in the patch? Are we sure node_diff['name'] is getting properly escaped somewhere else?
Thanks.
Comment #3
moonray CreditAttribution: moonray commentedWow, that sort of snuck in there while I was playing around with the code. New patch has those changes removed.
Comment #4
dwwYes, that looks much better, thanks. ;) I'll try it out in the next few days if possible, and commit.
Comment #5
dwwI re-reviewed this, tested it to reproduce the bug and confirmed the patch solves it, and committed a slightly modified version to HEAD, DRUPAL-5 and DRUPAL-4-7. Basically, I really didn't like how some of the diff.css changes looked when rendered on the scree, so I removed this:
And the
font-size: 79%;
for table.diff td. The primary functionality still works, but the diff is no longer displayed in ugly, small courier. ;)Thanks!
-Derek
Comment #6
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.