The full trace is attached, in 2 parts.

CommentFileSizeAuthor
#23 linkchecker_1901018+ERROR+clone+method+called+on+non+object-D6.patch12.33 KBhass
#21 linkchecker_1901018+ERROR+clone+method+called+on+non+object-D6.patch12.25 KBhass
#18 linkchecker_1901018+ERROR+clone+method+called+on+non+object.patch9.72 KBhass
#15 linkchecker_1901018+ERROR+clone+method+called+on+non+object.patch9.11 KBhass
#14 linkchecker_1901018+ERROR+clone+method+called+on+non-object.patch9.11 KBhass
#12 linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch9.11 KBhass
#10 linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch9.11 KBhass
#8 linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch9.12 KBhass
trace part b.png1.22 MBAnonymous (not verified)
trace part a.png1.12 MBAnonymous (not verified)

Comments

mikeytown2’s picture

mikeytown2 commented
Project: HTTP Parallel Request & Threading Library » Link checker
Version: 7.x-1.9 » 7.x-1.x-dev

Moving this to the link checker module as the trigger point is inside of it
http://drupalcode.org/project/linkchecker.git/blob/695417fe05f7d01f5266f...

The function in question comment_load can return an object or FALSE. link checker does not see if the comment was loaded correctly, thus when clone gets ran against the Boolean FALSE clone fails.

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.x-1.x-dev » 7.x-1.0

Pertains to Link Checker 7.x-1.0.

hass’s picture

hass commented

Same could happen in:

653 $block_custom = linkchecker_block_custom_block_get($row->bid);
654 $block_custom_original = clone $block_custom;
hass’s picture

hass commented
Version: 7.x-1.0 » 7.x-1.x-dev
hass’s picture

hass commented

@mikey: Do you have an idea how I can repro that comment_load() returns FALSE? I see it in the code, but I don't understand how it's possible to run into this except I'm loading invalid cids...? But how should this happen?

mikeytown2’s picture

mikeytown2 commented

My guess is some sort of bulk operation that didn't invoke hook_comment_delete. The other option is the database got disconnected at the right time; something strange happened with an entity field cache. The error backtrace looks fairly odd in the report so I'm guessing that something unexpected happened on the server.

Anonymous’s picture

Anonymous (not verified) commented

Re #6: I can support this hypothesis. While tracking down several unexpected and seemingly unrelated fatal PDO Exceptions on the primary key front, I found that the Feeds module -- and now I am speaking technically -- had "gone haywire". For reasons unknown to me it had been stepping all over the {node} and other related DB tables by inserting rows totally unrelated to actual site content. I used Feeds a while ago to import some D6 data, but don't need it now. Now that Feeds has been uninstalled and the DB cleaned up to remove its unwanted handywork, the PDO Exceptions problem as well as the issue reported here has gone away, AFAIK.

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch9.12 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch9.11 KB

Fixed comments

Status: Needs review » Needs work

The last submitted patch, linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch9.11 KB

Status: Needs review » Needs work

The last submitted patch, linkchecker_1901018+ERROR+__clone+method+called+on+non-object.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new linkchecker_1901018+ERROR+clone+method+called+on+non-object.patch9.11 KB

Heck... file name troubles? Reattaching with changed file name.

hass’s picture

hass commented
StatusFileSize
new linkchecker_1901018+ERROR+clone+method+called+on+non+object.patch9.11 KB

Status: Needs review » Needs work

The last submitted patch, linkchecker_1901018+ERROR+clone+method+called+on+non+object.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review

This applies all cleanly. Broken bot.

hass’s picture

hass commented
StatusFileSize
new linkchecker_1901018+ERROR+clone+method+called+on+non+object.patch9.72 KB

New patch

hass’s picture

hass commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Fixed

D7: http://drupalcode.org/project/linkchecker.git/commit/91502fb

hass’s picture

hass commented
Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)
hass’s picture

hass commented
Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Fixed » Needs review
StatusFileSize
new linkchecker_1901018+ERROR+clone+method+called+on+non+object-D6.patch12.25 KB

Patch attached

Status: Needs review » Needs work

The last submitted patch, linkchecker_1901018+ERROR+clone+method+called+on+non+object-D6.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review
StatusFileSize
new linkchecker_1901018+ERROR+clone+method+called+on+non+object-D6.patch12.33 KB
hass’s picture

hass commented
Status: Needs review » Fixed

http://drupalcode.org/project/linkchecker.git/commit/983ba26

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.