Undefined index: style_plugin in gmap_views_ajax_data_alter() of gmap.module

Thx for this great module!

I get the same message since I added a contextual filters for current node ID in my Gmap view.
Everything is working but this message keeps showing up, 2 times per node from the only content type that contain locations and use gmap.

Notice: Undefined index: style_plugin en gmap_views_ajax_data_alter() (línea 1367 de /sites/all/modules/gmap/gmap.module).

Hi, this patch work for me. I just added a index validation.

Works for me thx :-)

Btw.

  if (! (in_array ('gmap', $plugin_styles) || in_array ('gmap', $plugin_styles)))
    return;

in my opinion should look like
if (! (in_array ('gmap', $plugin_styles))) retrun ;

looks like test bot unhappy (

this needs updating tests

@podarok, seems there is a general error in the tests. Below error also appears in #1926360:
PHP Fatal error: Call to undefined function gmap_todim() in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/gmap/tests/gmap.test on line 22

#6
yes - tests for gmap module a old and with deprecated functions in it
we need update em for successfull "need review" process

possibly in follow-up

#2: gmap-undefined-style-plugin-1890460-1782709.patch queued for re-testing.

testbot happy
looks like #4 reasonable for me

can You update a patch with it?

Fresh patch including #3 and #4 and code styling.
These kind of patches seem more like symptom-busting then root cause analysis, but "a'-la"

good to see tests here for page generating Notice( /tests/gmap.test )

A quick re-roll of the patch in #10

@podarok: What would you like to test for? This issue seems clear enough.

2 #12
Good to see here a test reproducing notice

#10: gmap_1890460_10_plugin_style_error.patch queued for re-testing.

#12 commited pushed to 7.x-2.x
thanks

status for tests