Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Refer to the latest patch for details.
Comment | File | Size | Author |
---|---|---|---|
#12 | 1844266-12-spelling.patch | 7.08 KB | TR |
| |||
#6 | 1844266-6-spelling.patch | 7.88 KB | TR |
|
Comments
Comment #1
ashwinshCreated a path for the same.
Comment #3
ashwinshComment #4
ashwinshComment #5
jweowu CreditAttribution: jweowu at Catalyst IT commentedComment #6
TR CreditAttribution: TR commentedWell if it's going to take 9 years just to correct spelling, we might as well do it all at once. Here's a fix for all the spelling errors reported by codespell, which includes the error from above.
Comment #7
jweowu CreditAttribution: jweowu at Catalyst IT commentedCheers TR. By way of explanation, this was one of multiple patches I'd created after I'd spotted a spelling mistake in one module and then searched for and found the same mistake in several other modules I was using. I hadn't gone looking for additional errors in any of them, but you've certainly turned up a bunch!
Looks good to me. Confirming as still RTBC.
Comment #8
Liam MorlandIt would be helpful to put this patch into an issue fork.
Comment #9
jweowu CreditAttribution: jweowu at Catalyst IT commentedFeel free to do that. The traditional approach to issue queue patches is not in any way deprecated (to my knowledge), so I'm not sure how it would help; but if you believe it would make it more likely for this to be fixed then go for it.
Comment #10
jweowu CreditAttribution: jweowu at Catalyst IT commentedComment #11
Liam MorlandUsing an issue fork means that merging is one click and re-rolling after other commits is often one click as well. Patches that do not apply are a thing of the past.
In the DrupalCon North America 2021 Driesnote, he proposed more fully adopting GitLab and moving away from current issue queues, so the patch workflow may be deprecated shortly.
Though the most important thing that we need is an active maintainer for D7 in this module.
Comment #12
TR CreditAttribution: TR commentedUnfortunately, the spelling mistakes in the original post are in translatable strings. Fixing these mistakes will break translations. That's not something we can do in a minor point release of Rules. So we're stuck with those errors until D7 EOL.
The other mistakes are in comments, so they can be fixed now. Here's a new patch with only the "fixable" mistakes.
Comment #14
TR CreditAttribution: TR commentedCommitted #12.
Comment #16
jweowu CreditAttribution: jweowu at Catalyst IT commentedThe notion of being "stuck with spelling mistakes" seems much too silly to be true. Surely English translations can be added for the misspelled text (translating to the correct spelling) ?
That is definitely possible via
$conf['locale_custom_strings_en']
so I'd be surprised if it wasn't possible via other translation systems as well.Comment #17
TR CreditAttribution: TR commentedYes, it's been very frustrating dealing with this in Drupal over the years. The rules are that breaking changes can't be made between minor point releases. That has meant that changes to translatable strings can't be made until a new major release. That has been true of D5, D6, and D7. The situation has improved in D8, but there are still considerations on when changes like this may be introduced.
There are workarounds. You can patch your own site, or you can use the string_translations module to essentially translate English-to-English, or you can use variable overrides like you suggest, or you can hook_form_alter() things, but what you can't do is change a translatable string directly in the code because then all the sites using languages other than English will suddenly see that string as untranslated.
If we change translatable strings now, that creates an admittedly minor problem for hundreds of thousands of sites that either use translations or have taken steps to correct this problem on their own. But it does create a problem, and that's not something I want to do for a supposedly stable and near-EOL D7 release. I would prefer that this module just continue to work as it always has, rather than surprise people by introducing an error on their sites.
I personally would have committed this change 9 years ago when the problem was first raised, and made an effort at that time to check on ALL translatable strings. That would have broken some sites, but back then D7 was cutting edge, this module was being actively developed and wasn't on as many sites, and people expected changes between versions. Now, with the module stagnant for many years, people expect stability and aren't likely to either update or to notice the breakage when they do update.
Comment #18
jweowu CreditAttribution: jweowu at Catalyst IT commentedFair enough then. Thank you for taking the time to elaborate.