My category description use the Full HTML text format. When viewing FAQ pages the HTML is escaped and displayed. Rendering the category description should respect the text format.

CommentFileSizeAuthor
#11 1828758-11-category-descriptions-dont-respect-text-formats.patch3.06 KBcboyden
#4 1828758-4-category-descriptions-dont-respect-text-formats.patch4.07 KBsutharsan
#4 interdiff-1828758-1-4.txt1.33 KBsutharsan
#1 1828758-1-category-descriptions-dont-respect-text-formats.patch2.88 KBmstrelan

Comments

mstrelan’s picture

mstrelan commented
Status: Active » Needs review
StatusFileSize
new 1828758-1-category-descriptions-dont-respect-text-formats.patch2.88 KB

Ok here's a patch. Starting to think using FAQ module is more trouble than it's worth.

mrfelton’s picture

mrfelton commented

Patch works, thanks.

csc4’s picture

csc4 commented
Status: Needs review » Reviewed & tested by the community

As patch was tested and said to work in December... any chance please that it could get committed?

sutharsan’s picture

sutharsan commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff-1828758-1-4.txt1.33 KB
new 1828758-4-category-descriptions-dont-respect-text-formats.patch4.07 KB

Attached patch fixes two more places where check_markup() is used without the selected term format.

annya’s picture

annya commented

#4 works great. Thanks Sutharsan

annya’s picture

annya commented
Status: Needs review » Reviewed & tested by the community

I think we can set up patch #4 as reviewed.

csc4’s picture

csc4 commented

Any chance of getting this committed please?

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Reviewed & tested by the community » Fixed

#4 commited
Thanks!

  • podarok_auto committed 483d550 on 7.x-2.x authored by Sutharsan 
    Issue #1828758 by Sutharsan, mstrelan: Fixed Category descriptions don't...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cboyden’s picture

cboyden commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Patch (to be ported)
StatusFileSize
new 1828758-11-category-descriptions-dont-respect-text-formats.patch3.06 KB

The patch was committed to the 2.x branch, but this is still a problem in the 1.x branch and #4 no longer applies cleanly. Here's a re-rolled version.

markusd1984’s picture

markusd1984 commented

Sorry I'm not sure i fully understand, is this patch supposed to disable or enable HTML markup?

I'm using FCKEditor and made part of the Category description bold but it displays it as <strong> BOLD TEXDT </strong>.
Only in the FAQ description, it works, displaying it bold.