Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Since we provide the means to filter on severity the data column needs to be an index to prevent a whole table read.
Comment | File | Size | Author |
---|---|---|---|
#18 | d7-backport-1827136-18.patch | 629 bytes | posulliv |
#7 | severity_dbtng-1827136-7.patch | 702 bytes | patrickd |
#3 | dblog-AddIndex-1827136-3.patch | 701 bytes | amatzies |
#1 | dblog-AddIndex-1827136-1.patch | 376 bytes | amatzies |
Comments
Comment #1
amatzies CreditAttribution: amatzies commentedThis patch adds the index.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedWhile the patch adds the index for new installations you didn't supply a hook_update_N to modify the existing tables.
Comment #3
amatzies CreditAttribution: amatzies commentedThanks for the feedback. I added the hook_update_N now.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedYou need to set the status to "needs review" when adding a patch for the testbot to see it.
Comment #5
patrickd CreditAttribution: patrickd commentedworks for me (there's a missing dot at the end of the comment though)
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedThen let us be nit-picky.
Comment #7
patrickd CreditAttribution: patrickd commentedsame as #3, but with dot
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedI think the testbot had a hiccup in its get-up-and-go.
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commented#7: severity_dbtng-1827136-7.patch queued for re-testing.
Comment #12
patrickd CreditAttribution: patrickd commented#7 now it's green, weird bot
Comment #13
Anonymous (not verified) CreditAttribution: Anonymous commentedYea, the testbot had an issue and the was requeued by the testbot admin. Unfortunately that doesn't reset the Status.
Comment #14
catchPlease post a before/after EXPLAIN on the query this index affects.
Since this needs backport to Drupal 7, I think we can actually skip adding the update to Drupal 8 (as long as it does actually get backported).
Comment #15
Anonymous (not verified) CreditAttribution: Anonymous commentedWithout:
With:
Comment #16
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #17
catchThanks!
I removed the update function from the patch and committed/pushed this one to 8.x. Moving to 7.x for backport. Tagging with 'revisit before release' so this doesn't get lost if it's never committed to 7.x for any reason.
Comment #18
posulliv CreditAttribution: posulliv commentedPatch to backport to D7.
Comment #19
droplet CreditAttribution: droplet commentedPatch looks good.
Comment #20
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/b5d7ec6
(Note that I fixed a couple small documentation issues on commit: The function was in the wrong docgroup, since this is not part of the Drupal 6-to-7 upgrade, and the grammar on the function PHPDoc needed a little work.)