I just noticed that scanner errors from ClamAVDaemonScanner::scan() were not getting picked up by the module because there was a constant with a hex value that the module wasn't listening for. This made me think that the scan methods should be reporting back the same constants that the module is expecting to avoid any confusion - it's the API that the module is dictating.

Anyway, this patch removes the custom constants and sends scan responses using the constants that the module is expecting.

Comments

kevin hankens’s picture

Any thoughts on this one?

kevin hankens’s picture

Status: Active » Needs review
StatusFileSize
new4.08 KB

Oh, just realized that the patch wasn't uploaded :)

Status: Needs review » Needs work

The last submitted patch, antivirus_constants.patch, failed testing.

kevin hankens’s picture

That's strange, the patch applies cleanly for me when I apply it to HEAD on 7.x-1.x :/

kevin hankens’s picture

Status: Needs work » Needs review

#2: antivirus_constants.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, antivirus_constants.patch, failed testing.

kevin hankens’s picture

Status: Needs work » Needs review
StatusFileSize
new4.19 KB

I think I made the patch before #1811514 was committed. I'm re-rolling this one for testing.

erikwebb’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.