I just noticed that scanner errors from ClamAVDaemonScanner::scan() were not getting picked up by the module because there was a constant with a hex value that the module wasn't listening for. This made me think that the scan methods should be reporting back the same constants that the module is expecting to avoid any confusion - it's the API that the module is dictating.
Anyway, this patch removes the custom constants and sends scan responses using the constants that the module is expecting.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | antivirus_constants_1811474_7.patch | 4.19 KB | kevin hankens |
| #2 | antivirus_constants.patch | 4.08 KB | kevin hankens |
Comments
Comment #1
kevin hankens commentedAny thoughts on this one?
Comment #2
kevin hankens commentedOh, just realized that the patch wasn't uploaded :)
Comment #4
kevin hankens commentedThat's strange, the patch applies cleanly for me when I apply it to HEAD on 7.x-1.x :/
Comment #5
kevin hankens commented#2: antivirus_constants.patch queued for re-testing.
Comment #7
kevin hankens commentedI think I made the patch before #1811514 was committed. I'm re-rolling this one for testing.
Comment #8
erikwebb commentedThanks!
http://drupalcode.org/project/antivirus.git/commit/6d22e81