Change 'Diff' to 'Compare revisions' in tabs for easier translation [#1780480]

Comment	File	Size	Author
#9	1780480_workbench_moderation_Change+Diff+to+Compare+revisions+in+tabs+for+easier+translation.patch	916 bytes	hass

#6	1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch	916 bytes	hass

#2	1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation-2.patch	1.1 KB	iStryker

#1	1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation.patch	889 bytes	hass

Comment #1

hass CreditAttribution: hass commented 10 September 2012 at 19:18

Title:	Change Diff to Differences in tabs for easier translation	» Change 'Diff' to 'Differences' in tabs for easier translation
Status:	Active	» Needs review

File	Size
1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation.patch	889 bytes

Patch attached.

Log in or register to post comments

Comment #1.0

hass CreditAttribution: hass commented 10 September 2012 at 19:18

Issue summary:

View changes

a

Log in or register to post comments

Comment #2

iStryker CreditAttribution: iStryker commented 14 September 2012 at 18:25

Status:

Needs review

» Reviewed & tested by the community

File	Size
1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation-2.patch	1.1 KB

Patch applied against 7.x-1.x branch & 7.x-1.2 cleanly.

I have re-rolled the patch to change the diff buttom from "Show diff" to "Show differences" on node/%node/moderation/diff

Marking reviewed & tested by the community

Log in or register to post comments

Comment #3

hass CreditAttribution: hass commented 15 September 2012 at 21:46

Isn't this not something that need to be fixed in the Diff module itself?

See diff.pages.inc, Line 115.

Log in or register to post comments

Comment #4

hass CreditAttribution: hass commented 15 September 2012 at 21:48

#1 is RTBC, #2 seems to be an incorrect fix. We need to fix this string in the Diff module.

Log in or register to post comments

Comment #5

hass CreditAttribution: hass commented 15 September 2012 at 22:11

#1785742: Diff module string review

Log in or register to post comments

Comment #6

hass CreditAttribution: hass commented 16 September 2012 at 15:25

Title:

Change 'Diff' to 'Differences' in tabs for easier translation

» Change 'Diff' to 'Compare revisions' in tabs for easier translation

File	Size
1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch	916 bytes

Per discussion in #1404642: Better diff integration we are changing the wording to be more user friendly.

Log in or register to post comments

Comment #7

16 September 2012 at 15:27

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch, failed testing.

Log in or register to post comments

Comment #8

hass CreditAttribution: hass commented 16 September 2012 at 15:33

Status:

Needs work

» Needs review

#6: 1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch queued for re-testing.

Log in or register to post comments

Comment #9

hass CreditAttribution: hass commented 16 September 2012 at 15:34

File	Size
1780480_workbench_moderation_Change+Diff+to+Compare+revisions+in+tabs+for+easier+translation.patch	916 bytes

Stupid robot cannot download files with spaces.

Log in or register to post comments

Comment #10

iStryker CreditAttribution: iStryker commented 17 September 2012 at 11:51

Are title automatically translated, or should it be t('Compare revisions').

Log in or register to post comments

Comment #11

hass CreditAttribution: hass commented 17 September 2012 at 12:22

Menu titles are automatically translated or what title's do you mean? Any line numbers, so we can look into? See http://api.drupal.org/api/drupal/modules!system!system.api.php/function/hook_menu/7 for the menu path docs, please.