Tabs should not named with the module that is behind a tab. It should name the functionality for usability reasons.

CommentFileSizeAuthor
#9 1780480_workbench_moderation_Change+Diff+to+Compare+revisions+in+tabs+for+easier+translation.patch916 byteshass
#6 1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch916 byteshass
#2 1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation-2.patch1.1 KBistryker
#1 1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation.patch889 byteshass

Comments

hass’s picture

hass commented
Title: Change Diff to Differences in tabs for easier translation » Change 'Diff' to 'Differences' in tabs for easier translation
Status: Active » Needs review
StatusFileSize
new 1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation.patch889 bytes

Patch attached.

hass’s picture

hass commented
Issue summary: View changes

a

istryker’s picture

istryker commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 1780480_workbench_moderation_Change+Diff+to+Differences+in+tabs+for+easier+translation-2.patch1.1 KB

Patch applied against 7.x-1.x branch & 7.x-1.2 cleanly.

I have re-rolled the patch to change the diff buttom from "Show diff" to "Show differences" on node/%node/moderation/diff

Marking reviewed & tested by the community

hass’s picture

hass commented

Isn't this not something that need to be fixed in the Diff module itself?

See diff.pages.inc, Line 115.

hass’s picture

hass commented

#1 is RTBC, #2 seems to be an incorrect fix. We need to fix this string in the Diff module.

hass’s picture

hass commented

#1785742: Diff module string review

hass’s picture

hass commented
Title: Change 'Diff' to 'Differences' in tabs for easier translation » Change 'Diff' to 'Compare revisions' in tabs for easier translation
StatusFileSize
new 1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch916 bytes

Per discussion in #1404642: Better diff integration we are changing the wording to be more user friendly.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Needs review

#6: 1780480_workbench_moderation_Change+Diff+to+Compare revisions+in+tabs+for+easier+translation.patch queued for re-testing.

hass’s picture

hass commented
StatusFileSize
new 1780480_workbench_moderation_Change+Diff+to+Compare+revisions+in+tabs+for+easier+translation.patch916 bytes

Stupid robot cannot download files with spaces.

istryker’s picture

istryker commented

Are title automatically translated, or should it be t('Compare revisions').

hass’s picture

hass commented

Menu titles are automatically translated or what title's do you mean? Any line numbers, so we can look into? See http://api.drupal.org/api/drupal/modules!system!system.api.php/function/hook_menu/7 for the menu path docs, please.

istryker’s picture

istryker commented
Status: Needs review » Reviewed & tested by the community

@hass, thats what I thought. Thanks for clarifying it for us.

hass’s picture

hass commented
Issue tags: +Workbench Sprint
stevector’s picture

stevector
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

http://drupal.org/commitlog/commit/18554/342a5703c97caad860d8907af2c8efa...

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

a