Notice: Undefined property: stdClass::$commerce_product in commerce_decimal_quantities_form_commerce_order_ui_order_form_alter() (line 81 in /sites/all/modules/contrib/commerce_decimal_quantities/commerce_decimal_quantities.module).
Warning: Invalid argument supplied for foreach() in commerce_decimal_quantities_form_commerce_order_ui_order_form_alter() (line 81 in /sites/all/modules/contrib/commerce_decimal_quantities/commerce_decimal_quantities.module).

This problem occurs when order have line item without product reference like shipping line item.

CommentFileSizeAuthor
#7 commerce_decimal_quantities-product_reference_check-1760770-7.patch1.95 KBGaborTorok
#1 1760770-1.patch2.53 KB5n00py

Comments

5n00py’s picture

5n00py commented
Status: Active » Needs review
StatusFileSize
new 1760770-1.patch2.53 KB

Very simple patch :)

guy_schneerson’s picture

guy_schneerson commented

Thanks @5n00py, looks good will try and review and commit soon

5n00py’s picture

5n00py commented

@guy_schneerson Any progress?

guy_schneerson’s picture

guy_schneerson commented

This patch fixes the problem however the original code should ideally be reviewed as it should use commerce_product_line_item_types() to check if line item is a product and also the second loop look may be redundant.

committed http://drupalcode.org/project/commerce_decimal_quantities.git/commit/c18...

guy_schneerson’s picture

guy_schneerson commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

GaborTorok’s picture

GaborTorok commented
Status: Closed (fixed) » Needs review
StatusFileSize
new commerce_decimal_quantities-product_reference_check-1760770-7.patch1.95 KB

This problem was reintroduced at another place with the addition of commerce_decimal_quantities_field_widget_form_alter() in commit http://drupalcode.org/project/commerce_decimal_quantities.git/commit/33b...

I inserted a check that solves the problem for me. Patch attached.

guy_schneerson’s picture

guy_schneerson commented

thanks @GaborTorok will review and commit

5n00py’s picture

5n00py commented
Status: Needs review » Reviewed & tested by the community

I'll test patch from #7. It fix the problem and everything looks good!

guy_schneerson’s picture

guy_schneerson commented
Status: Reviewed & tested by the community » Fixed

Thanks @GaborTorok & @5n00py great work
Committed http://drupalcode.org/project/commerce_decimal_quantities.git/commit/06d...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.