Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.this is a simple patch to put the "Location(s)" title in a separate classed div, so that it can be modified via CSS.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | location-172646-8.patch | 385 bytes | BWPanda |
| #1 | location.module.maps_.patch | 394 bytes | Anonymous (not verified) |
| location.module.title_.patch | 1.01 KB | Anonymous (not verified) | |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedThis similarly puts the the "See map: " section of node output into its own div which both allows it to be themed and resolves a problem I had where there was no line break between the location output and the start of the next field.
Comment #2
catchDuplicate:
http://drupal.org/node/161703 - also had patch
Comment #3
YesCT CreditAttribution: YesCT commentedI think that issue number had a typo in it, as it did not appear to be related.
I do remember reading an issue that talked about changing the map link. I'll try and find it and post back.
Also tagging.
Comment #4
YesCT CreditAttribution: YesCT commentedhere it is.
#182786: Open map links in new window is related kind of.
Also, adding a tag.
Comment #5
YesCT CreditAttribution: YesCT commentedmarked #335955: Small display fix as a duplicate. It has sample code for adding a div too.
Comment #6
YesCT CreditAttribution: YesCT commentedmarked #375127: Minor UI improvement on user page as a duplicate. It suggested using paragraph tags to improve spacing.
Comment #7
YesCT CreditAttribution: YesCT commentedrelated #396610: Theming seperate locations within same node wants to remove the links.
Comment #8
BWPanda CreditAttribution: BWPanda commentedHere's a patch for the latest .dev version. Can we get this committed?
Comment #9
Melissamcewen CreditAttribution: Melissamcewen commentedWhy hasn't this patch been committed yet?
echo $map_link;seems to still not have a class.Comment #10
Melissamcewen CreditAttribution: Melissamcewen commentedOK, I am now reviewing this patch:
* Is the patch in unified diff format? +/- is good >< is bad? Yes
* Does the patch meet Drupal's coding standards? I don't see any.
* Is the code secure? Yes.
* If the patch makes major changes to a function or adds a new one, does it have appropriate code comments? No, it does not make major changes or a function or add a new one.
* Is the patch likely to cause performance issues? No
* Does the patch add theme functions or .tpl.php files where appropriate? Not applicable I think.
* If new pages are added, are they are in a logical place? If forms or other UI elements are added, are they intuitive and logical to use? Does it come with appropriate contextual help? Is the interface consistent? Not applicable
* If the patch is adding new functionality, does this apply only to the specific area it's affecting in core, or can it be applied to other areas and in contrib? Not applicable
Comment #11
YesCT CreditAttribution: YesCT commentedComment #12
ankur CreditAttribution: ankur commentedComitted to DRUPAL-6--3 and HEAD
Comment #13
YesCT CreditAttribution: YesCT commentedhttp://drupal.org/cvs?commit=347448
http://drupal.org/cvs?commit=347446