This module needs to be updated to run on the drupal 6 branch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

Priority: Normal » Critical
Status: Active » Needs review
FileSize
3.92 KB

There's still something wrong with the menu, not sure what though. It's reporting Invalid argument supplied for foreach(), so we must be doing something wrong here....

netbjarne’s picture

I'm just hanging on here - been poormanscron fan since 4.something.

Bjarne

RobLoach’s picture

Status: Needs review » Needs work

If anyone figures out what's wrong with the menu in that patch, please let me know. I'm curious as to what I'm doing wrong.

RobLoach’s picture

Status: Needs work » Needs review
FileSize
4.18 KB

It seemed the issue was with my cache, it's working now. Updated patch with UNIX end lines and a documentation fix. Good to be reviewed by you guys.

RobLoach’s picture

Does this branch need a maintainer? Because I'd be willing to help out with that...

litwol’s picture

i think it does.

chb’s picture

Just tried to apply the patch to cvs from 05.02.2008, something gone wrong:

(Stripping trailing CRs from patch.)
patching file README.txt
Hunk #1 FAILED at 16.
1 out of 1 hunk FAILED -- saving rejects to file README.txt.rej
(Stripping trailing CRs from patch.)
patching file poormanscron.info
Hunk #1 succeeded at 1 with fuzz 1.
(Stripping trailing CRs from patch.)
patching file poormanscron.module
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 9.
Hunk #3 succeeded at 51 (offset -3 lines).
Hunk #5 FAILED at 95.
3 out of 5 hunks FAILED -- saving rejects to file poormanscron.module.rej
RobLoach’s picture

Oh, sorry... This is leading off of the DRUPAL-5 branch, because that is the one that was most recently updated.

chb’s picture

Thanks for pointing that out. Now it looks like as if the patch is already applied, so I just need to bump the Version number to 6.x. I get

warning: Missing argument 1 for poormanscron_menu() in /var/www/vhosts/httpdocs/blog/sites/all/modules/poormanscron/poormanscron.module on line 104.

I'm using Drupal-6 rc3, maybe something else has changed.

RobLoach’s picture

Status: Needs review » Fixed

I've fixed up HEAD to include the hook_menu fixes from my patch, some watchdog API changes in Drupal 6, and poormanscron.admin.inc, which hooks into the menu system. Do you think we should make the DRUPAL-6--1 branch?

chb’s picture

I just installed it so far it is working, thanks :-). I really would like to have a drupal-6 branch but I can't contribute much code to it...

ax’s picture

as Dries created the DRUPAL-6 branch for core, meaning that HEAD isn't necessarily compatible with Drupal 6 anymore, i just created the corresponding DRUPAL-6--1 CVS branch and the development snapshot release for this module. please do all Drupal 6 development on this branch now.

RobLoach’s picture

Thanks, ax!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.