Fill PDF uses Webform Rules to help provide a default rule - one of emailing the PDF upon Webform submission. The current official release of Webform is still 7.x-3.18. The latest version of Webform Rules only works with Webform 4.x, and there is no easy way to obtain a Webform 3-compatible version.

Is it possible to revert the changes that broke Webform 3.x compatibility and create a new branch of Webform Rules that chases Webform 4.x? It would then also be possible to commit the Webform Tokens compatibility fix and then to address upgrade path in the Webform Rules 7.x-2.x branch specifically.

I'd appreciate this a lot. I will probably eventually propose a patch if you don't have time, though I don't have the Git access to do the branch stuff. Please let me know what you think is the best.

Comments

jibus’s picture

jibus commented

I think a new branch dedicated to the 4.x version of Webform should be create

firfin’s picture

firfin commented

drush automated updates keep trashing my compatibility. Just saying, it is still an issue.

Meanwhile, what do we think about the following workarounds?
- https://drupal.org/project/update_advanced
- drush up --lock=webform_rules
- who name it ...

firfin’s picture

firfin commented

Just to follow up. I took the leap and upgraded webform from 3.x to 4.x
Updating webforms took some work. But at least I got a LOT less problems and errors.
So, no longer any interest in workarounds. For now.

johnennew’s picture

johnennew commented

Upgrading webform isn't always an option. There is the ability to tell drush to stop updating this module but it's still really annoying. Modules depending on webform_rules might be (actually are) slow to catch up. A simple drush up update will break compatibility since drush won't switch webform to version 4 but will switch webform_rules to the webform 4 dependant version.

This is a breaking change and so it should have a new major release to give site owners the option of deciding if they want to make the change.

johnennew’s picture

johnennew commented

Also, webform 7.x-4.x is still in alpha so we shouldn't be forcing this onto people's sites.

Angry Dan’s picture

Angry Dan commented

This is a big problem, you now can't maintain changes against the 3.x branch - if you have any bugs filed against the 3.x branch you won't be able fix them. This module should have one branch per release branch of webform.

This is the equivalent of putting the D7 version of your module inside the D6 branch and saying "this update requires an upgrade to Drupal 7" on the release notes.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Version: 7.x-1.x-dev » 7.x-1.5
Status: Active » Fixed

Now both versions are suported.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.