Machine name of generated block too long - breaking the block listing.

Thanks for this great module. It's quite complex to properly add ad DFP to a Drupal site and the module comes in very handy.

There is no other report about this bug. So I assume it is still in the dev, but I didn't verify that.

The error:

PDOException: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'delta' at row 1: INSERT INTO {block} (module, delta, theme, status, weight, region, pages, cache) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7);

[...]

db_insert_placeholder_1 is 34 characters long. I follow the naming guide of DFP, which is recommended in an official tutorial video at YouTube: sitename_category_adformat_dimensions

The error occurs when opening /admin/structure/block. Are the blocks created first when opening the blocks listing? Seems so. It breaks the blocks listing for admins.

It's a common situation, because many modules (e.g. Panels) don't check for the length restrictions of the db when creating blocks. A quick fix for users would be to change the machine_name maximum length at db level.

Another quick solution: disable the block feature in Ad tag configuration. I'm lucky blocks were just a 'nice to have' feature for me. Unchecking "Create a block for this ad tag" helps (verified!).

I suggest to create the DFP blocks not when showing the administrative blocks listing, but when saving the Ad tag. This kind of errors would raise in place then and it would be easier to identify their origin.