I updated colorbox from 7.x-1.1 to 7.x-1.3 and the images formatted using IC proportions stop working. If I change the image to just use colorbox or to just use IC_proportions with a link to image rather than a colorbox modal, it works as expected. So I'm guessing that colorbox has updated something. I tested CB 1.2 and it also doesn't work so it is something which was introduced at the CB 1.2 release.

I have duplicated the problem with a test site on localhost as well. the errors thrown are:
Notice: Undefined index: colorbox_node_style in theme_colorbox_image_formatter() (line 30 of /Applications/MAMP/htdocs/drupal714/sites/all/modules/colorbox/colorbox.theme.inc).
Notice: Undefined index: colorbox_caption in theme_colorbox_image_formatter() (line 38 of /Applications/MAMP/htdocs/drupal714/sites/all/modules/colorbox/colorbox.theme.inc).
Notice: Undefined index: colorbox_gallery in theme_colorbox_image_formatter() (line 79 of /Applications/MAMP/htdocs/drupal714/sites/all/modules/colorbox/colorbox.theme.inc).
Notice: Undefined index: colorbox_image_style in theme_colorbox_image_formatter() (line 99 of /Applications/MAMP/htdocs/drupal714/sites/all/modules/colorbox/colorbox.theme.inc).

Thanks
Bernie

CommentFileSizeAuthor
#8 colorbox_support-1671470-8.patch9.73 KBplopesc
#7 colorbox_support-1671470-7.patch4.96 KBplopesc
#2 colorbox-1671470_3.patch977 bytesnonsie
#1 colorbox-1671470_2.patch889 bytesnonsie

Comments

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
Status: Active » Needs review
StatusFileSize
new colorbox-1671470_2.patch889 bytes

This makes the module work with Colorbox 1.4. Caption and gallery are hardcoded and should probably become settings.

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
StatusFileSize
new colorbox-1671470_3.patch977 bytes

Better patch that deals with "Undefined index: entity keys in entity_extract_ids()" notices.

vgutekunst’s picture

vgutekunst commented
Status: Needs review » Closed (works as designed)

thank u very much nonsie! it works!

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented
Status: Closed (works as designed) » Reviewed & tested by the community

Please don't close it -it still needs to be committed for others to use.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs review

please don't RTBC your own patches :)

Thanks btw!

vgutekunst’s picture

vgutekunst commented

colorbox works now with the patch, but it doestn show me alt-text or title-text from the images. Any possibility to add this function in ur patch too?

regards

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new colorbox_support-1671470-7.patch4.96 KB

Hello
Attaching patch which adds full support for colorbox module. It has been tested against Colorbox 7.x-2.4.

Regards.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new colorbox_support-1671470-8.patch9.73 KB

New patch giving full support for colorbox 7.x-2.4 and shadowbox 7.x-3.0-rc2.

Regards.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Fixed

Patch committed.

Thanks.

http://drupalcode.org/project/imagecache_proportions.git/commit/69ebbad

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 69ebbad on 7.x-1.x, 8.x-1.x by plopesc: 
    Issue #1671470 by nonsie, plopesc | BernieCram: Imagecache proportions...