Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When I took a look at the code I saw some typos and I fixed them.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | flattr-typo-fixes-1513974-1.patch | 750 bytes | yannickoo |
Comments
Comment #1
yannickooComment #2
Letharion commentedThank you. :)
Comment #3
yannickooPlease don't forget to attribute authorship to me with adding
--author="yan_nick <yan_nick@531118.no-reply.drupal.org>"to the commit message ;)Comment #4
Letharion commentedI actually thought for a moment about authorship, but since you hadn't used format-patch but a regular diff, and I couldn't find the documentation for it right away, I just went with the oldschool 'By yannickoo' and applied it. :)
Honestly, I think I will always be to lazy to take the time to go to individual users pages and copy/paste their authorship info. If someone wants credit for a patch, I will expect it either exported with format-patch, or as a fork of the project to a sandbox. This puts the responsibility of authorship handling on the actual author, not the commiter, which makes sense to me.
Comment #5
yannickooWhat is a "format-patch"? But I think it's the only way to give some credits to the patches' author.
Comment #6
Letharion commentedIt is definitely not the only way :) And in my opinion, it's the worst, as it relies on me to remember and do extra work. I found some more info on format-patch here.
Comment #7
yannickooThanks for the information :)