Failed to Geocode

not really sure where that right parentheses is coming from. Yea there isn't really a way to re-geocode like re-downloading the images. However, when you add a field mapping it will reset the hash to '', causing the import process to re-process that listing. So you can either add and then remove a field mapping, or open mysql and run a query to UPDATE drealty_listing SET hash = ''; or something similar to force all the listings to be reprocessed.

Which geocoder handler are you using to do the geocoding? I used to use Google, however they have a limit of 1500 per day, i have started using Yahoo! Placefinder and the results are just as accurate, and they're daily limit is 20k or something like that.

This happens to me too with Innovia vendor for properties that already have lat/long coordinates saved. When I update the listing in drush, it throws that error for every listing. If I clear coordinates out and rerun, no error.

I saw that happen too. What's the harm in overwriting the value or having them set as NULL instead of 0?

actually, the geocoding does overwrite the values...

basically the when a listing is processed it loops through all the mappings that are defined...

  foreach($field_mappings as $mapping) {
    ....
    // $item->latitude = $rets_item['latitude'];
    $item->$mapping->field_name = $rets_item[$mapping->systemname];
    ....
  }

Once it's done doing the field mappings, then it checks to see if we are geocoding this 'class'

  if ($class->do_geocoding) {
            $street_number = isset($item->street_number) ? $item->street_number : '';
            $street_name = isset($item->street_name) ? $item->street_name : '';
            $street_suffix = isset($item->street_suffix) ? $item->street_suffix : '';

            $geoaddress = "{$street_number} {$street_name} {$street_suffix}, {$item->city}, {$item->state_or_province} {$item->postal_code}";
            // remove any double spaces
            $geoaddress = str_replace("  ", "", $geoaddress);

            if ($latlon = drealty_geocode($geoaddress, $class->geocoder_handler)) {
              if ($latlon->success) {
                $item->latitude = $latlon->lat;
                $item->longitude = $latlon->lon;
                drush_log(dt('Geocoded: @address to (@lat, @lon)', array('@address' => $geoaddress, '@lat' => $item->latitude, '@lon' => $item->longitude)));
              } else {
                drush_log(dt('Failed to Geocode: @address)', array('@address' => $geoaddress)));
              }
            } else {
              drush_log(dt('Failed to Geocode: @address)', array('@address' => $geoaddress)));
            }
  }

   $item->latitude = $latlon->lat;
   $item->longitude = $latlon->lon;

The two lines above essentially overwrite the value of anything that was pulled from the rets feed for lat and lon.

** well i figured out where the ')' was coming from this is on line 474 and 477 of drealty.daemon.php.

  drush_log(dt('Failed to Geocode: @address)', array('@address' => $geoaddress)));
  //should read
  drush_log(dt('Failed to Geocode: @address', array('@address' => $geoaddress)));

So, something is causing the geocoding to fail. Since you are using the yahoo placefinder, did you set the yahoo app id in the:

admin/config/content/geocoder

reason i ask is because, it won't complain if you don't have it set and will 'act' like it is set, but fail to geocode anything.

Let me know.

I think I 'may' have figured out the problem.

            $street_number = isset($item->street_number) ? $item->street_number : '';
            $street_name = isset($item->street_name) ? $item->street_name : '';
            $street_suffix = isset($item->street_suffix) ? $item->street_suffix : '';

            $geoaddress = "{$street_number} {$street_name} {$street_suffix}, {$item->city}, {$item->state_or_province} {$item->postal_code}";

right now i'm concatenating the address out of these fields:

"{street_number} {street_name} {street_suffix}, {city}, {state} {postal_code}"

However if you've mapped:

street_dir_prefix or street_dir_suffix 

They never get put into the address, so the address should be put together like this:

"{street_number} {street_dir_prefix} {street_name} {street_dir_suffix} {street_suffix}, {city}, {state} {postal_code}"

Let me know if you've mapped either of those fields. If so i'll make the changes post haste and get them pushed up to see if it works. If not, then back to the drawing board.

well i just pushed up a new release that should address not mapping those fields. so if they're mapped they'll now be included:

            $geoaddress = isset($item->street_number) ? $item->street_number : '';
            $geoaddress .= isset($item->street_dir_prefix) ? $item->street_dir_prefix : '';
            $geoaddress .= isset($item->street_name) ? $item->street_name : '';
            $geoaddress .= isset($item->street_dir_suffix) ? $item->street_dir_suffix : '';
            $geoaddress .= isset($item->street_suffix) ? $item->street_suffix : '';
            $geoaddress .= ", {$item->city}, {$item->state_or_province} {$item->postal_code}";

is how the address is built now.

I'm also thinking that it might not be a bad idea to include an option for encoding based on the unparsed_address or encoding based on a concatenated address, i'll add that to the todo list.

oh snap, i see the problem, thanks!

there's a new release up there or you can grab the latest from git, via a 'git pull'.

Additionally, can you check to ensure that you don't have the field 'L_AddressDirection' mapped twice?

you can open phpmyadmin or another mysql tool and run this query:

SELECT * FROM `drealty_field_mappings` WHERE `systemname` = 'L_AddressDirection'

and see if it's there more than once.

Glad to hear that it's now working for you!

Can anyone else confirm that this is working for them?

I was having issues in my setup where the address_number and address_street were right up against each other... This was with beta18. In my case it was because the double-space replace in the geoaddress is replacing double spaces with no space at all. It seems like it should replace a double space with a single space, correct? Thus:

// remove any double spaces
$geoaddress = str_replace(" ", " ", $geoaddress);

That fixed my issue. anyway...

Yea, i feared that may cause problems, there has to be a more elegant solution in how i'm putting together the address. I'll do some research and see what i can come up with.

Seems like this should be closed? 3.x uses AddressField/Geo.

Using AddressField + GeoField + Geocoder has been pretty straight in 3.x. Please re-open if this continues to occur.