use two most recent tags as defaults

Wouldn't this need to add an error if tag1 is defined but tag2 is not for parameters?

Subscribing. Excellent improvement.

Do it. 90% use case is to build a changelog from the previous tag (or to start of repo) to the current tag. Second parameter can be an optional specified treeish. Much better, IMO.

So is this still Needs Review, or were the above reactions RTBC-but-wait-scope-shift? comments?

/New Maintainer has Spoken

Why don't we support it? We can compute any parameters we need for git log. This tool kind of presumes a vague familiarity with git, but does not require knowledge of it.

Consistency I understand, we can have:

* old new
* <calculated previous> new
* <calculated previous to previous> <calculated previous>

Trying to make the proposition clearer:
#8 suggests:

drush rn <start> <end>  // all arguments provided.
drush rn <end>          // the <start> is calculated. As "one before <end>"
drush rn                // both <end> and <start> are calculated. As "latest" and "one before latest"

Note: please try and use the <start> and <end> when referring to those arguments.
A decision has been made to refer to them like that. So let's not stray from that please :)

see #1494488: git version 1.7.9, --reverse mandatory for the error, i assume it's the same git version.

i applied the patch and ran drush rn --reverse and it returned the latest changes between the last two tags

Sounds like this is RTBC. Go grayside!

How can this be RTBC if it only works when using an option of another patch?

Actually, it works fine without --reverse when using the patch in #10.

I haven't applied #1494488: git version 1.7.9, --reverse mandatory.

After using this for a while, I saw some room for improvement... I keep several branches in parallel, and using this without args was using the most advanced branch always. I modified the code to fetch the current branch and only search in tags of the same pattern. Also, it was assuming you had more than 1 tag in the list, which can easily be the case if the tag list is restricted by the current branch.

This patch was created with diff, not git diff, so no need to apply with -p1.

This works for me without the patch from (http://drupal.org/node/1494488#comment-5769416), but ...

The --reverse tag is ignored on my system, the output with and without the tags is always in the same order. To debug I added drush_print_r(sprintf("%s log -s --pretty=format:%%s%s %s..%s", $git, $reverse, $tag1, $tag2)); behind $reverse = drush_get_option('reverse', FALSE) ? ' --reverse' : ''; so i could see what gets executed.

While running those commands on the command line, the --reverse works ;p

After applying the patch from http://drupal.org/node/1494488#comment-5769416 the --reverse is working again. So it's probably related to the drush version.

Included a patch that combines both patches.

can somebody give feedback please

I still need to use this patch with the latest dev version

http://drupalcode.org/project/grn.git/commit/fe186f3

Hurray! :)