hi Robin,

cloned the source last week and found several issues with it,
have been cleaning those up and restructuring the module, a fork with the changes is available on github: https://github.com/g10/Menu-Service
several minor issues have been fixed in the meanwhile it seems

some other changes/additions that have been made are:
- changed package to 'Services - resources' (grouping of non-core resources -> this would be handy for all non-core resources, similar to services 2.x where they are grouped under 'Services - services')
- renamed the .inc file to services_menu.resource.inc (in line with services and services_view modules)
- the use of value objects to return the data (and allow some filtering of the fields -> imho the theming data is not relevant to return, only adds bloat, but this has to be discussed: which fields are relevant and the best way to filter them -> for now, the filtering is done based on the available vars in de value object)
- adds the path alias

feel free to merge the changes back you find useful/appropriate

Comments

Robin van Emden’s picture

Robin van Emden CreditAttribution: Robin van Emden commented

Hi G10,
Thank you for your feedback. Nice to work together with other devs on this. I will check your changes and additions and merge them as appropriate.
(btw: great theme @ formapparatus.com)

Robin van Emden’s picture

Robin van Emden CreditAttribution: Robin van Emden commented
Title: Invitation to merge with branch on GitHub » adjusted version

Merged g10's git branch (from https://github.com/g10/Menu-Service), cleaned it up to make it pass Coder modules review, reverted to default args implementation (named args did not work on our test-server).

Also decided to revert to dependencies[] without 3.x, because of #1013302: Versioned dependencies fail with dev versions and git clones

Robin van Emden’s picture

Robin van Emden CreditAttribution: Robin van Emden commented
Title: adjusted version » Invitation to merge with branch on GitHub
Assigned: Unassigned » Robin van Emden
Status: Active » Closed (fixed)
g10’s picture

g10 CreditAttribution: g10 commented
Title: adjusted version » Invitation to merge with branch on GitHub

The args implementation is kind of an issue on it's own: #1217602: Uniform service arguments declaration
I developed against a patched version of amf_server which implemented a named array (as their was a bug in it #1218070: correct argument parsing)

Which server implementation did you use?

Robin van Emden’s picture

Robin van Emden CreditAttribution: Robin van Emden commented

Hi g10, I was already aware of these issues. I will keep an eye on them!