Rename ambiguous "edit foo" permission to "edit all foo"

Assuming the only place this lives is in node.module, this patch should do it.

I'll roll patches for 5.x and 4-7 if we'd like to backport...

Huge +1...are there any other places that *check* this permission that need changing? Like node_access() or something.

The permission at present would read e.g. 'edit story content', which at least is clearer than 'edit story', but I agree that 'edit all story content' better conveys the difference between this permission and the 'edit own story content' permission.

are there any other places that *check* this permission that need changing? Like node_access() or something.

Yes, the if ($op == 'delete') section of node_content_access() needs updating.

Also we would need an _update function to update existing permissions.

It looks to me like the $op == 'update' needs updating (rather than delete).

I'd love to roll another patch, but I'm not sure where _update functions go in version 6 (especially since node doesn't have a *.install file)...

It seems like we're talking about an update permissions table. Is there a cleaner way to update it than a RegEx on the perm field?

+1

This is usability, people. Can we still get this into D6?

+1 (It took me a while to figure out that I needn't to assign "edit story contents" to make "edit own story contents" working, when I tried with Drupal first time.)

There's already at least one patch with renamed permission committed: http://drupal.org/node/181088 - may be useful to look in there for the upgrade function. (BTW - if node have no .install file, we should probably add one?)

Attaching a new patch:
- Both edit and delete permissions renamed to edit all and delete all
- Upgrade path included (updating the new delete permission too, just in case someone goes from a 6.x-beta)
- I did a full search on core files: No more places to update permission names.
- Fully tested by me (but needs more review, as usually here)

I hope this might be able to go into 6.x, still. Usability stuff.

Re-rolling...

Opinions / feedback / reviews welcome. It would be nice to hear, whether this is for D6 still.

Massive +1 from me. Tested the patch and it works fine, applies with some offset. Upgrade path is consistent with previous permission changes this cycle although I didn't test it. Should be RTBC though.

Ack!

I just took a closer look at the permissions page, now we have "delete x content" permissions this won't work:

Obviously someone could go through every post on a site individually, deleting them one by one, but we don't want to give the impression there's a one click delete function sitting somewhere if this is enabled!

So I think we should change this to "delete any x content" to make it less ambiguous.

OK quick re-roll with 'any' for review. If people think my problems with "edit all" are a false alarm, then I'd still be happy for it to be committed, either "all " or "any" would be better than nothing.

Rerolled to remove offset. Also your quick edit changed one instance of "own" to "any", but luckily outside changed lines, so it would just make a bit of fuzz on applying. Now corrected.

Otherwise I quite agree that "any" is even more accurate. Feel free to RTBC again, if appropriate.

JirkaRybka - did you mean to attach something? ;)

Oh, a reminder "didn't you forget something" on submit would be definitely nice! ;)
I'm sorry...

Now attaching.

I think this is good to go then.

I think this is a good improvement, but one more pair of eyes to look on whether we miss some permission usage or not would be appreciated.

Well, I grepped Drupal core, and it looks like polls have the same problem still. Ie. "edit polls" and "edit own poll". Let's get this sorted out quickly, so we can get this into Drupal 6 finally.

- We don't need to update the delete permissions since we don't support HEAD to HEAD upgrades.
- All updates for Drupal 6 should be system.install and not the individual install files (in this case node.install)

Ok, improved patch:

- Polls included. Permissions "create polls", "edit polls", "edit own poll" changed to "create poll content", "edit any poll content", "edit own poll content".
- By the way, I discovered one instance of "edit own polls" access check, which was obviously a bug.

As for #18 - I feel really uneasy about making things *worse* just for consistency here. Deliberately breaking 6.0-beta installs, seems wrong to me. Also having all core updates concentrated in system.install (which is a scary monster now) seems not very nice to me, especially when there are already separate updates for book, comment, locale, statistics (and possibly more, I didn't check all).

But since this is beyond scope for this issue, and I see your points are valid from the current-state consistency perspective, I changed the patch:

- Upgrade path for 6.0-beta existing "delete foo content", "edit polls", and "edit own poll" now *NOT* provided.
- Update now rolled as system_update_6038()

Re-rolled. (Just an offset - huge one, but nothing broken.)

Ready then!

Upgrade path for

- edit polls => edit any poll content
- edit own polls => edit own poll content

missing.

These are NOT missing. These are REMOVED per #18 - just like the general delete stuff, these are new 6.x permissions, existing on our recent betas, but not on 5.x. I may easily add them all back into the patch, but only if someone confirm that we DO support upgrades from beta releases. I'm unsure on this, and the only clear feedback I got on this is #18.

I checked poll.module for Drupal 5, and indeed, it does not have its own editing permissions. Committed.