Hey,
I just took a look at workbench, I was surprised by the label "Content I've edited" because its very uncommon in Drupal to use contractions and it also denotes the importance of it being mine. I would suggest a label (for only this block) such as "My recently edited content". Leading with the most important part of this label.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | my_edits_1182724_11.patch | 3.6 KB | stevector |
| #10 | 1182724-workbench-my-edits.patch | 4.54 KB | dave reid |
| #9 | my_edits__view_only_1182724_9.patch | 1.52 KB | stevector |
| #3 | view_title_change-1182724-3.patch | 2.79 KB | stevector |
Comments
Comment #1
caroltron commentedThank you Bojhan for the suggestion. I agree with you that "My recently edited content" is a much better label for this block and the subsequent view. We'll get this change rolled out in the next release.
Comment #2
dave reidI agree as well.
Comment #3
stevectorPatch attached.
Comment #4
stevectorI am taking myself off the assignment so someone else can review.
Comment #5
dave reidPatch looks good initially, will give it a quick visual review.
Comment #6
yoroy commentedMy cut-another-50% suggestion would then be "My recent edits".
Comment #7
dave reid@yoroy: How about "My edits"?
Comment #8
yoroy commentedNice catch :) "Most recent first" is pretty much an expected ordering here. Both would work I think. I don't have workbench running here so have no picture on where this little block title lives on the page.
Comment #9
stevectorDavereid mentioned in IRC that he's improving workbench.pages.inc. Here's the View only.
Comment #10
dave reidHere's what I had, but I'm experiencing a problem with the 'All recent content' view displaying no items.
Comment #11
stevectorDave Reid, I am not able to recreate the Views problem you describe.
Here is an updated patch. It removes a dpm() and a call to check_plain(). The View title is already getting sanitized though I'm not sure where exactly.
This patch also leaves out the change views/workbench_recent_content.view.inc from the patch in #10. I don't necessarily object to changing that empty text but it seems outside the scope of this issue.
Comment #12
dave reidWell if you're not having the view problem, then #11 looks good to me!
Comment #13
stevectorhttp://drupalcode.org/project/workbench.git/commit/f1356c7